book: fix contradictory description of foo(NULL) overload resolution#312
Merged
Conversation
The narrative claimed foo(NULL) calls foo(int), but the code comment (and clang, the compiler the example recommends) says it does not compile. These contradicted each other. The behavior is actually implementation-dependent: with NULL defined as 0 (e.g. MSVC) it calls foo(int); with NULL defined as the GCC/Clang builtin __null it is ambiguous and fails to compile. Reword to make this explicit, which also addresses the MSVC observation in the report. Fixes #301
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The narrative claimed
foo(NULL)callsfoo(int), but the code comment (and clang, the recommended compiler) says it does not compile. These contradicted each other. The behavior is implementation-dependent:NULLas0(e.g. MSVC) → callsfoo(int);NULLas the GCC/Clang builtin__null→ ambiguous, fails to compile. Reword to make this explicit, which also addresses the MSVC observation in the report.Fixes #301