chore(repo): re-enable eslint for @clerk/ui#9218
Conversation
The lint script was renamed to `lint:disabled` in 4da7668 so turbo's `lint` task would stop matching it. Rename it back and clear the 117 errors that had accumulated. Notable: - Physical `left`/`right`/`paddingLeft` replaced with logical properties in OrganizationMembers and SetupMfaStartScreen (broken in RTL). - Non-null assertions removed from slot-recipe and BaseRouter. - `no-navigate-useClerk` and `no-unstable-methods` now registered for packages/ui, where the migrated components live. No new violations. - a11y heading/label rules off for mosaic: its `render` prop indirection makes both rules report on every usage.
🦋 Changeset detectedLatest commit: 59c4ef2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughThe PR enables additional UI ESLint rules and updates related package configuration. It replaces physical horizontal CSS properties with logical properties in organization and MFA components, adds targeted suppressions for intentional physical positioning, and refactors several parsing, routing, machine, and caching implementations without changing their stated behavior. Numerous source and test files also receive import ordering, formatting, unused-import, JSX shorthand, and type-test updates. A UI TypeScript path alias and patch changeset are added. Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Comment |
No description provided.