Skip to content

chore(repo): re-enable eslint for @clerk/ui#9218

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/ui-linting
Jul 22, 2026
Merged

chore(repo): re-enable eslint for @clerk/ui#9218
alexcarpenter merged 2 commits into
mainfrom
carp/ui-linting

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Jul 22, 2026

Copy link
Copy Markdown
Member

No description provided.

The lint script was renamed to `lint:disabled` in 4da7668 so turbo's
`lint` task would stop matching it. Rename it back and clear the 117
errors that had accumulated.

Notable:
- Physical `left`/`right`/`paddingLeft` replaced with logical properties
  in OrganizationMembers and SetupMfaStartScreen (broken in RTL).
- Non-null assertions removed from slot-recipe and BaseRouter.
- `no-navigate-useClerk` and `no-unstable-methods` now registered for
  packages/ui, where the migrated components live. No new violations.
- a11y heading/label rules off for mosaic: its `render` prop indirection
  makes both rules report on every usage.
@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 59c4ef2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jul 22, 2026 6:17pm
swingset Ready Ready Preview, Comment Jul 22, 2026 6:17pm

Request Review

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T18:17:48.588Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 59c4ef2.

@pkg-pr-new

pkg-pr-new Bot commented Jul 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9218

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9218

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9218

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9218

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9218

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9218

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9218

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9218

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9218

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9218

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9218

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9218

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9218

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9218

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9218

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9218

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9218

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9218

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9218

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9218

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9218

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9218

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9218

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9218

commit: 59c4ef2

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The PR enables additional UI ESLint rules and updates related package configuration. It replaces physical horizontal CSS properties with logical properties in organization and MFA components, adds targeted suppressions for intentional physical positioning, and refactors several parsing, routing, machine, and caching implementations without changing their stated behavior. Numerous source and test files also receive import ordering, formatting, unused-import, JSX shorthand, and type-test updates. A UI TypeScript path alias and patch changeset are added.

Estimated code review effort: 3 (Moderate) | ~25 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No actual pull request description was provided, so the change intent can't be assessed from author text. Add a brief description of the lint re-enable work, RTL CSS fixes, and custom rule/config updates.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change: restoring ESLint for @clerk/ui and related lint cleanup in packages/ui.

Comment @coderabbitai help to get the list of available commands.

@alexcarpenter
alexcarpenter merged commit 1c52591 into main Jul 22, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/ui-linting branch July 22, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants