feat(elements): Add /sign-in export, remove hardcoded paths by brkalow · Pull Request #2662 · clerk/javascript

brkalow · 2024-01-24T20:38:10Z

Description

Moves sign-in components to a /sign-in export.
Also refactors the machine to not rely on hardcoded sign in paths, instead deriving the base path from the Clerk router.
Removes unnecessary @clerk/nextjs dependency

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Packages affected

…dcoded /sign-in path

changeset-bot · 2024-01-24T20:38:15Z

🦋 Changeset detected

Latest commit: 7e9c51b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/elements	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brkalow · 2024-01-26T21:16:03Z

!snapshot

clerk-cookie · 2024-01-26T21:19:19Z

Hey @brkalow - the snapshot version command generated the following package versions:

Package	Version
@clerk/backend	1.0.1-snapshot.vc65ad98
@clerk/chrome-extension	1.0.1-snapshot.vc65ad98
@clerk/clerk-js	5.0.1-snapshot.vc65ad98
@clerk/elements	0.0.2-snapshot.vc65ad98
@clerk/clerk-expo	1.0.1-snapshot.vc65ad98
@clerk/fastify	1.0.1-snapshot.vc65ad98
gatsby-plugin-clerk	5.0.1-snapshot.vc65ad98
@clerk/localizations	2.0.1-snapshot.vc65ad98
@clerk/nextjs	5.0.1-snapshot.vc65ad98
@clerk/clerk-react	5.0.1-snapshot.vc65ad98
@clerk/remix	4.0.1-snapshot.vc65ad98
@clerk/clerk-sdk-node	5.0.1-snapshot.vc65ad98
@clerk/shared	2.0.1-snapshot.vc65ad98
@clerk/themes	2.0.1-snapshot.vc65ad98
@clerk/types	4.0.1-snapshot.vc65ad98

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.0.1-snapshot.vc65ad98 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.1-snapshot.vc65ad98 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.0.1-snapshot.vc65ad98 --save-exact

@clerk/elements

npm i @clerk/elements@0.0.2-snapshot.vc65ad98 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.0.1-snapshot.vc65ad98 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.1-snapshot.vc65ad98 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.1-snapshot.vc65ad98 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.0.1-snapshot.vc65ad98 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.1-snapshot.vc65ad98 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.0.1-snapshot.vc65ad98 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.1-snapshot.vc65ad98 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.1-snapshot.vc65ad98 --save-exact

@clerk/shared

npm i @clerk/shared@2.0.1-snapshot.vc65ad98 --save-exact

@clerk/themes

npm i @clerk/themes@2.0.1-snapshot.vc65ad98 --save-exact

@clerk/types

npm i @clerk/types@4.0.1-snapshot.vc65ad98 --save-exact

brkalow · 2024-01-26T21:57:12Z

!snapshot

clerk-cookie · 2024-01-26T22:00:45Z

Hey @brkalow - the snapshot version command generated the following package versions:

Package	Version
@clerk/backend	1.0.1-snapshot.v8b7e4f0
@clerk/chrome-extension	1.0.1-snapshot.v8b7e4f0
@clerk/clerk-js	5.0.1-snapshot.v8b7e4f0
@clerk/elements	0.0.2-snapshot.v8b7e4f0
@clerk/clerk-expo	1.0.1-snapshot.v8b7e4f0
@clerk/fastify	1.0.1-snapshot.v8b7e4f0
gatsby-plugin-clerk	5.0.1-snapshot.v8b7e4f0
@clerk/localizations	2.0.1-snapshot.v8b7e4f0
@clerk/nextjs	5.0.1-snapshot.v8b7e4f0
@clerk/clerk-react	5.0.1-snapshot.v8b7e4f0
@clerk/remix	4.0.1-snapshot.v8b7e4f0
@clerk/clerk-sdk-node	5.0.1-snapshot.v8b7e4f0
@clerk/shared	2.0.1-snapshot.v8b7e4f0
@clerk/themes	2.0.1-snapshot.v8b7e4f0
@clerk/types	4.0.1-snapshot.v8b7e4f0

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/elements

npm i @clerk/elements@0.0.2-snapshot.v8b7e4f0 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.1-snapshot.v8b7e4f0 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/shared

npm i @clerk/shared@2.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/themes

npm i @clerk/themes@2.0.1-snapshot.v8b7e4f0 --save-exact

@clerk/types

npm i @clerk/types@4.0.1-snapshot.v8b7e4f0 --save-exact

brkalow · 2024-01-26T22:12:48Z

!snapshot

brkalow · 2024-01-26T22:15:42Z

 {
  "name": "@clerk/elements",
-  "version": "0.0.2-beta-v5.8",
-  "private": true,


TODO: we can add "private": "true" back until we're ready to publish openly.

clerk-cookie · 2024-01-26T22:16:41Z

Hey @brkalow - the snapshot version command generated the following package versions:

Package	Version
@clerk/backend	1.0.1-snapshot.vcaceed6
@clerk/chrome-extension	1.0.1-snapshot.vcaceed6
@clerk/clerk-js	5.0.1-snapshot.vcaceed6
@clerk/elements	0.0.2-snapshot.vcaceed6
@clerk/clerk-expo	1.0.1-snapshot.vcaceed6
@clerk/fastify	1.0.1-snapshot.vcaceed6
gatsby-plugin-clerk	5.0.1-snapshot.vcaceed6
@clerk/localizations	2.0.1-snapshot.vcaceed6
@clerk/nextjs	5.0.1-snapshot.vcaceed6
@clerk/clerk-react	5.0.1-snapshot.vcaceed6
@clerk/remix	4.0.1-snapshot.vcaceed6
@clerk/clerk-sdk-node	5.0.1-snapshot.vcaceed6
@clerk/shared	2.0.1-snapshot.vcaceed6
@clerk/themes	2.0.1-snapshot.vcaceed6
@clerk/types	4.0.1-snapshot.vcaceed6

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.0.1-snapshot.vcaceed6 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.1-snapshot.vcaceed6 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.0.1-snapshot.vcaceed6 --save-exact

@clerk/elements

npm i @clerk/elements@0.0.2-snapshot.vcaceed6 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.0.1-snapshot.vcaceed6 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.1-snapshot.vcaceed6 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.1-snapshot.vcaceed6 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.0.1-snapshot.vcaceed6 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.1-snapshot.vcaceed6 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.0.1-snapshot.vcaceed6 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.1-snapshot.vcaceed6 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.1-snapshot.vcaceed6 --save-exact

@clerk/shared

npm i @clerk/shared@2.0.1-snapshot.vcaceed6 --save-exact

@clerk/themes

npm i @clerk/themes@2.0.1-snapshot.vcaceed6 --save-exact

@clerk/types

npm i @clerk/types@4.0.1-snapshot.vcaceed6 --save-exact

brkalow · 2024-01-26T22:51:54Z

!snapshot

clerk-cookie · 2024-01-26T22:55:00Z

Hey @brkalow - the snapshot version command generated the following package versions:

Package	Version
@clerk/backend	1.0.1-snapshot.v7e9c51b
@clerk/chrome-extension	1.0.1-snapshot.v7e9c51b
@clerk/clerk-js	5.0.1-snapshot.v7e9c51b
@clerk/elements	0.0.2-snapshot.v7e9c51b
@clerk/clerk-expo	1.0.1-snapshot.v7e9c51b
@clerk/fastify	1.0.1-snapshot.v7e9c51b
gatsby-plugin-clerk	5.0.1-snapshot.v7e9c51b
@clerk/localizations	2.0.1-snapshot.v7e9c51b
@clerk/nextjs	5.0.1-snapshot.v7e9c51b
@clerk/clerk-react	5.0.1-snapshot.v7e9c51b
@clerk/remix	4.0.1-snapshot.v7e9c51b
@clerk/clerk-sdk-node	5.0.1-snapshot.v7e9c51b
@clerk/shared	2.0.1-snapshot.v7e9c51b
@clerk/themes	2.0.1-snapshot.v7e9c51b
@clerk/types	4.0.1-snapshot.v7e9c51b

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.0.1-snapshot.v7e9c51b --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.1-snapshot.v7e9c51b --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.0.1-snapshot.v7e9c51b --save-exact

@clerk/elements

npm i @clerk/elements@0.0.2-snapshot.v7e9c51b --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.0.1-snapshot.v7e9c51b --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.1-snapshot.v7e9c51b --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.1-snapshot.v7e9c51b --save-exact

@clerk/localizations

npm i @clerk/localizations@2.0.1-snapshot.v7e9c51b --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.1-snapshot.v7e9c51b --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.0.1-snapshot.v7e9c51b --save-exact

@clerk/remix

npm i @clerk/remix@4.0.1-snapshot.v7e9c51b --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v7e9c51b --save-exact

@clerk/shared

npm i @clerk/shared@2.0.1-snapshot.v7e9c51b --save-exact

@clerk/themes

npm i @clerk/themes@2.0.1-snapshot.v7e9c51b --save-exact

@clerk/types

npm i @clerk/types@4.0.1-snapshot.v7e9c51b --save-exact

LekoArts · 2024-02-05T13:29:30Z

This PR was superseded by #2725 and #2676

brkalow added 2 commits January 24, 2024 14:33

feat(elements): Move SignIn components to /sign-in export, remove har…

db567b5

…dcoded /sign-in path

chore(repo): Add changeset

8766d22

brkalow requested a review from tmilewski January 24, 2024 20:38

clerk-cookie added the elements label Jan 24, 2024

brkalow added 2 commits January 26, 2024 14:56

Merge branch 'main' into brk.chore/refactor-elements-build

8724cc4

fix(elements): Ignore attw failure

e32b196

clerk-cookie added the actions label Jan 26, 2024

chore(elements): Add changeset to trigger snapshot

c65ad98

chore(elements): Remove clerk/nextjs dependency

8b7e4f0

chore(elements): Export SignIn as Root to match docs

caceed6

brkalow commented Jan 26, 2024

View reviewed changes

chore(elements): Adjust exports to match docs

7e9c51b

LekoArts added this to the @clerk/elements (Alpha) milestone Feb 1, 2024

LekoArts mentioned this pull request Feb 5, 2024

feat(elements): Remove hardcoded /sign-in path #2725

Merged

24 tasks

LekoArts closed this Feb 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(elements): Add /sign-in export, remove hardcoded paths#2662

feat(elements): Add /sign-in export, remove hardcoded paths#2662
brkalow wants to merge 8 commits into
mainfrom
brk.chore/refactor-elements-build

brkalow commented Jan 24, 2024 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jan 24, 2024 •

edited

Loading

Uh oh!

brkalow commented Jan 26, 2024

Uh oh!

clerk-cookie commented Jan 26, 2024

Uh oh!

brkalow commented Jan 26, 2024

Uh oh!

clerk-cookie commented Jan 26, 2024

Uh oh!

brkalow commented Jan 26, 2024

Uh oh!

brkalow Jan 26, 2024

Uh oh!

clerk-cookie commented Jan 26, 2024

Uh oh!

brkalow commented Jan 26, 2024

Uh oh!

clerk-cookie commented Jan 26, 2024

Uh oh!

LekoArts commented Feb 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

brkalow commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Packages affected

Uh oh!

changeset-bot Bot commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

brkalow commented Jan 26, 2024

Uh oh!

clerk-cookie commented Jan 26, 2024

Uh oh!

brkalow commented Jan 26, 2024

Uh oh!

clerk-cookie commented Jan 26, 2024

Uh oh!

brkalow commented Jan 26, 2024

Uh oh!

brkalow Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

clerk-cookie commented Jan 26, 2024

Uh oh!

brkalow commented Jan 26, 2024

Uh oh!

clerk-cookie commented Jan 26, 2024

Uh oh!

LekoArts commented Feb 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brkalow commented Jan 24, 2024 •

edited

Loading

changeset-bot Bot commented Jan 24, 2024 •

edited

Loading