Skip to content

chore(localizations): Update missing Russian translations - #4431

Merged
tmilewski merged 4 commits into
clerk:mainfrom
jonasboardwalker:chore/russian-localization
Nov 1, 2024
Merged

chore(localizations): Update missing Russian translations#4431
tmilewski merged 4 commits into
clerk:mainfrom
jonasboardwalker:chore/russian-localization

Conversation

@jonasboardwalker

Copy link
Copy Markdown
Contributor

Description

Thanks for reviewing my contribution to Clerk! This PR updates the missing Russian translations in the localization files, ensuring a more complete and accurate experience for Russian-speaking users.

Changes Introduced:

  • Added translations for previously missing keys in the ru-RU.ts localization file, enhancing the localization coverage for the Clerk SDK.
  • Ensured that all translations maintain consistency with the English counterparts in en-US.ts.

Testing the Change:

  • To test the changes, run the application in a localized environment with the Russian language setting to verify that all added translations display correctly.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • [] JSDoc comments have been added or updated for any package exports (if applicable).
  • [] Documentation has been updated (if applicable).

Type of change

  • 🔨 Chore (updating translations)

@changeset-bot

changeset-bot Bot commented Oct 30, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b71b631

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris changed the title chore(localization): update missing Russian translations chore(localization): Update missing Russian translations Nov 1, 2024
@LauraBeatris LauraBeatris changed the title chore(localization): Update missing Russian translations chore(localizations): Update missing Russian translations Nov 1, 2024
@jonasboardwalker

jonasboardwalker commented Nov 1, 2024

Copy link
Copy Markdown
Contributor Author

@LauraBeatris thanks for approving. Do you have an idea why integration tests are failing? Can it be caused by this PR?

@tmilewski

Copy link
Copy Markdown
Member

@LauraBeatris thanks for approving. Do you have an idea why integration tests are failing? Can it be caused by this PR?

@jonasboardwalker Your PR is fine, it's expected to fail in this scenario. It's because external contributors don't have access to the required GHA secrets.

@tmilewski

Copy link
Copy Markdown
Member

@jonasboardwalker Thank you!

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants