Skip to content

fix(upgrade): Update docs link for rendering modes - #4454

Closed
ubersan wants to merge 4 commits into
clerk:mainfrom
ubersan:fix-codemod-link
Closed

fix(upgrade): Update docs link for rendering modes#4454
ubersan wants to merge 4 commits into
clerk:mainfrom
ubersan:fix-codemod-link

Conversation

@ubersan

@ubersan ubersan commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Description

https://clerk.com/docs/nextjs/rendering-modes goes to 404, it's instead at a slightly different location.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: doc update

sorry no turborepo installed so couldn't run the npm stuff, but I'd assume things are okay

@changeset-bot

changeset-bot Bot commented Nov 1, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0bc8c73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/upgrade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris changed the title Update link to rendering modes in codemod success message. fix(upgrade): Update docs link for rendering modes Nov 1, 2024
@LauraBeatris

Copy link
Copy Markdown
Contributor

@ubersan Thanks for the contribution!

@LauraBeatris
LauraBeatris enabled auto-merge (squash) November 1, 2024 14:11
@LauraBeatris

Copy link
Copy Markdown
Contributor

Hey @ubersan, again thank you so much for opening this PR!

I'll have to close this PR. The GH actions are failing due to a current repo issue where secrets aren't shared with forks, we're working to fix that.

The fix is being shipped here

auto-merge was automatically disabled November 1, 2024 21:21

Pull request was closed

@ubersan

ubersan commented Nov 1, 2024

Copy link
Copy Markdown
Contributor Author

np, thanks for the update! sorry for missing the changeset, but glad its going out already!👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants