feat(clerk-js): Send FAPI version through URLSearchParams - #4457
Merged
Conversation
🦋 Changeset detectedLatest commit: 719394d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jacekradko
changed the title
jacekradko
marked this pull request as ready for review
November 1, 2024 20:32
panteliselef
reviewed
Nov 2, 2024
| }; | ||
|
|
||
| // This is the currently support version of the Frontend API | ||
| export const SUPPORTED_FAPI_VERSION = '2024-10-01'; |
Contributor
There was a problem hiding this comment.
I'm curious about FAPI versioning and keeping types in sync. The types package version and which FAPI version they represent.
jacekradko
commented
Nov 2, 2024
panteliselef
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to pass the FAPI version as a query param
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change