feat(clerk-js,elements,types,localization): Make legal consent stable - #4487
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ad198a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
force-pushed
the
vaggelis/remove-experimental-for-legal-accepted-at
branch
4 times, most recently
from
November 6, 2024 19:29
c8ae7f1 to
b6493fa
Compare
octoper
marked this pull request as ready for review
November 6, 2024 19:37
alexcarpenter
approved these changes
Nov 6, 2024
alexcarpenter
left a comment
Member
There was a problem hiding this comment.
Went through and tested different flows with no issues. Nice work.
Only had one comment on the checkbox label not dimming on submission similar to other checkboxes.
octoper
force-pushed
the
vaggelis/remove-experimental-for-legal-accepted-at
branch
2 times, most recently
from
November 7, 2024 14:02
d69c621 to
c0c0f14
Compare
anagstef
approved these changes
Nov 7, 2024
tmilewski
approved these changes
Nov 7, 2024
octoper
force-pushed
the
vaggelis/remove-experimental-for-legal-accepted-at
branch
3 times, most recently
from
November 8, 2024 15:33
b4e9297 to
86e67f1
Compare
octoper
enabled auto-merge (squash)
November 8, 2024 15:33
octoper
disabled auto-merge
November 8, 2024 15:33
octoper
enabled auto-merge (squash)
November 8, 2024 15:40
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>
octoper
force-pushed
the
vaggelis/remove-experimental-for-legal-accepted-at
branch
from
November 8, 2024 15:40
86e67f1 to
ad198a3
Compare
octoper
deleted the
vaggelis/remove-experimental-for-legal-accepted-at
branch
November 8, 2024 16:04
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
…#4487) Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR marks legal consent feature as stable
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change