Skip to content

feat(clerk-js,elements,types,localization): Make legal consent stable - #4487

Merged
octoper merged 9 commits into
mainfrom
vaggelis/remove-experimental-for-legal-accepted-at
Nov 8, 2024
Merged

feat(clerk-js,elements,types,localization): Make legal consent stable#4487
octoper merged 9 commits into
mainfrom
vaggelis/remove-experimental-for-legal-accepted-at

Conversation

@octoper

@octoper octoper commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

Description

This PR marks legal consent feature as stable

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@octoper octoper self-assigned this Nov 5, 2024
@changeset-bot

changeset-bot Bot commented Nov 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ad198a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/localizations Minor
@clerk/clerk-js Minor
@clerk/elements Minor
@clerk/types Minor
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
octoper force-pushed the vaggelis/remove-experimental-for-legal-accepted-at branch 4 times, most recently from c8ae7f1 to b6493fa Compare November 6, 2024 19:29
@octoper
octoper marked this pull request as ready for review November 6, 2024 19:37

@alexcarpenter alexcarpenter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through and tested different flows with no issues. Nice work.

Only had one comment on the checkbox label not dimming on submission similar to other checkboxes.

Comment thread packages/clerk-js/src/ui/elements/LegalConsentCheckbox.tsx Outdated
@octoper
octoper force-pushed the vaggelis/remove-experimental-for-legal-accepted-at branch 2 times, most recently from d69c621 to c0c0f14 Compare November 7, 2024 14:02

@anagstef anagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Comment thread packages/clerk-js/src/core/resources/SignUp.ts Outdated
Comment thread .changeset/twenty-rules-boil.md Outdated
@octoper
octoper force-pushed the vaggelis/remove-experimental-for-legal-accepted-at branch 3 times, most recently from b4e9297 to 86e67f1 Compare November 8, 2024 15:33
@octoper
octoper enabled auto-merge (squash) November 8, 2024 15:33
@octoper
octoper disabled auto-merge November 8, 2024 15:33
@octoper
octoper enabled auto-merge (squash) November 8, 2024 15:40
@octoper
octoper force-pushed the vaggelis/remove-experimental-for-legal-accepted-at branch from 86e67f1 to ad198a3 Compare November 8, 2024 15:40
@octoper
octoper merged commit cc24c81 into main Nov 8, 2024
@octoper
octoper deleted the vaggelis/remove-experimental-for-legal-accepted-at branch November 8, 2024 16:04
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
…#4487)

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants