fix(nextjs): Use next pathname and searchParams for router - #4492
Closed
alexcarpenter wants to merge 3 commits into
Closed
fix(nextjs): Use next pathname and searchParams for router#4492alexcarpenter wants to merge 3 commits into
alexcarpenter wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 49fa163 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dstaley
approved these changes
Nov 5, 2024
alexcarpenter
marked this pull request as draft
November 6, 2024 16:18
nikosdouvlis
approved these changes
Nov 7, 2024
Member
Author
|
Closing in favor of #4513 due to searchParams usage forcing client side rendering in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where the basePath was incorrect within elements router causing a shallow push to modify the pathname when moving between sign-in and sign-up flows.
BEFORE
Screen.Recording.2024-11-05.at.3.34.15.PM.mov
AFTER
Screen.Recording.2024-11-05.at.3.32.25.PM.mov
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change