feat(clerk-js,types): Surface enterprise accounts in `UserProfile` by LauraBeatris · Pull Request #4518 · clerk/javascript

LauraBeatris · 2024-11-07T20:29:03Z

Description

Resolves ORGS-293, ORGS-294

Surfaces user.enterprise_accounts instead of user.saml_accounts. This is going to support multiple enterprise protocols from now on, such as OpenID connect.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-11-07T20:29:06Z

🦋 Changeset detected

Latest commit: e71267b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/elements	Patch
@clerk/expo-passkeys	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/nextjs	Patch
@clerk/clerk-react	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/themes	Patch
@clerk/ui	Patch
@clerk/vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LauraBeatris · 2024-11-12T18:35:36Z

@NicolasLopes7 Preserving the disableAdditionalIdentifications check:

CleanShot.2024-11-12.at.15.31.01.mp4

panteliselef

🛳️

Previously, SAML was the only supported enterprise type, therefore the UI description was only based on `SamlIdpSlug` It'll now use `EnterpriseProvider` to handle multiple connection types.

Using `user.enterpriseAccounts` to display on `UserProfile`, instead of `user.samlAccounts` This is going to support the upcoming connection types such as EASIE, OIDC Also, deletes `useSaml` hook as it was a weak abstraction around SAML constants for logo URLs and naming

Refer to `user.enterprise_accounts` to verify if the user is allowed to introduce additional identifications

…4518)

LauraBeatris self-assigned this Nov 7, 2024

clerk-cookie added types clerk-js backend labels Nov 7, 2024

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch 2 times, most recently from 27932f1 to 4b3eb72 Compare November 7, 2024 20:47

clerk-cookie removed the backend label Nov 7, 2024

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch 2 times, most recently from db250d9 to 6a5ddaa Compare November 7, 2024 21:17

LauraBeatris changed the title ~~feat(clerk-js,backend,types): Display enterprise accounts on UserProfile~~ feat(clerk-js,types): Display enterprise accounts on UserProfile Nov 7, 2024

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch 4 times, most recently from 1815e12 to 16eda49 Compare November 8, 2024 00:24

LauraBeatris changed the title ~~feat(clerk-js,types): Display enterprise accounts on UserProfile~~ feat(clerk-js,types): Support multiple enterprise protocols in UserProfile Nov 8, 2024

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from 16eda49 to 094f540 Compare November 8, 2024 00:44

clerk-cookie added the playground label Nov 8, 2024

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from 094f540 to e5aa840 Compare November 8, 2024 00:46

clerk-cookie removed the playground label Nov 8, 2024

LauraBeatris commented Nov 8, 2024

View reviewed changes

Comment thread packages/clerk-js/src/ui/components/UserProfile/EnterpriseAccountsSection.tsx Outdated

LauraBeatris commented Nov 8, 2024

View reviewed changes

Comment thread packages/types/src/appearance.ts Outdated

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from e5aa840 to d270ba9 Compare November 12, 2024 17:39

LauraBeatris changed the title ~~feat(clerk-js,types): Support multiple enterprise protocols in UserProfile~~ feat(clerk-js,types): Surface enterprise accounts in UserProfile Nov 12, 2024

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from 1a29195 to e019947 Compare November 12, 2024 18:03

clerk-cookie added the playground label Nov 12, 2024

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from e019947 to d21ba70 Compare November 12, 2024 18:03

clerk-cookie removed the playground label Nov 12, 2024

LauraBeatris commented Nov 12, 2024

View reviewed changes

Comment thread packages/clerk-js/src/ui/components/UserProfile/AccountPage.tsx

izaaklauer approved these changes Nov 13, 2024

View reviewed changes

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch 2 times, most recently from 6751683 to 3a253db Compare November 13, 2024 17:08

panteliselef approved these changes Nov 13, 2024

View reviewed changes

Comment thread packages/types/src/appearance.ts

LauraBeatris added 20 commits November 13, 2024 15:09

Add EnterpriseAccount resource to backend layer

eced539

Add EnterpriseAccount to types layer

a3ca6c9

Add EnterpriseAccountResource to clerk-js

107dc77

Populate enterprise_accounts on User resource

0fe99f8

Verify if there are enterprise accounts to display

7b6c6de

Update UI description with new enterprise provider union

c83c34b

Previously, SAML was the only supported enterprise type, therefore the UI description was only based on `SamlIdpSlug` It'll now use `EnterpriseProvider` to handle multiple connection types.

Disallow user profile changes for multiple enterprise connection types

9ae6104

Refer to `user.enterprise_accounts` to verify if the user is allowed to introduce additional identifications

Introduce UI tests

7f5056d

Fix icon for SAML providers

f6e67ee

Update changeset

0b2e26f

Update firstName and lastName to be nullable

b037709

Update tests to rely on enterprise_accounts

efa346e

Add deprecation JSDocs

38750b2

Treat provider as strategy

75c913b

Add test for inactive connection

63c8e3c

Add generic descriptor for SSO connections

6f33bb6

Include generic providerInitialIcon descriptor

2c3ec62

Preserve ProviderInitialIcon descriptors

3e3cee6

Rely on FAPI for connection name and logo

d4cdd22

LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from 3a253db to d4cdd22 Compare November 13, 2024 18:09

Use CDN for provider logo

e71267b

LauraBeatris merged commit 1c0b500 into main Nov 13, 2024

LauraBeatris deleted the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch November 13, 2024 20:22

clerk-cookie mentioned this pull request Nov 13, 2024

ci(repo): Version packages #4546

Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025

feat(clerk-js,types): Surface enterprise accounts in UserProfile (#…

5662c59

…4518)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(clerk-js,types): Surface enterprise accounts in `UserProfile` - #4518

feat(clerk-js,types): Surface enterprise accounts in `UserProfile`#4518
LauraBeatris merged 21 commits into
mainfrom
laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts

LauraBeatris commented Nov 7, 2024 •

edited

Loading

Uh oh!

changeset-bot Bot commented Nov 7, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LauraBeatris commented Nov 12, 2024

Uh oh!

panteliselef left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

LauraBeatris commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LauraBeatris commented Nov 12, 2024

Uh oh!

panteliselef left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

LauraBeatris commented Nov 7, 2024 •

edited

Loading

changeset-bot Bot commented Nov 7, 2024 •

edited

Loading