fix(astro): Avoid importing transition functions when View Transitions is disabled - #4521
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 75852fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
changed the title
wobsoriano
commented
Nov 7, 2024
Member
Author
There was a problem hiding this comment.
We need to avoid importing functions from astro:transitions as there is a code that gets initialized and configures the popstate event which causes full page reload when doing custom client-side routing
wobsoriano
marked this pull request as ready for review
November 7, 2024 23:32
LekoArts
approved these changes
Nov 8, 2024
anagstef
approved these changes
Nov 8, 2024
panteliselef
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where custom client-side routing (using History API's pushState) triggers unexpected full page reloads due to conflicts with Astro's internal
popstateevent handlersResolves SDK-1976
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change