fix(clerk-js): Only apply id to FormFeedback when the type is error - #4552
Merged
alexcarpenter merged 5 commits intoNov 19, 2024
Conversation
🦋 Changeset detectedLatest commit: 82ae553 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
approved these changes
Nov 13, 2024
alexcarpenter
marked this pull request as draft
November 13, 2024 20:17
alexcarpenter
marked this pull request as ready for review
November 14, 2024 19:02
alexcarpenter
deleted the
alexcarpenter/fix-form-feedback-multiple-ids
branch
November 19, 2024 14:54
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where multiple elements in the dom include the same id attribute which leads to invalid markup and causes a11y issues.
Since we only apply
aria-describedbyon the input element when there is anerrorMessageId, we only apply the id to theFormFeedbackwhen its of typeerrorAfter:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change