fix(clerk-js): Ensure autofill event is triggered during sign-in - #4560
Merged
alexcarpenter merged 6 commits intoNov 15, 2024
Conversation
🦋 Changeset detectedLatest commit: 09aeb7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexcarpenter
marked this pull request as ready for review
November 14, 2024 18:49
…in-signin-and-signup-causes-first-click
tmilewski
approved these changes
Nov 14, 2024
…in-signin-and-signup-causes-first-click
panteliselef
approved these changes
Nov 15, 2024
…in-signin-and-signup-causes-first-click
alexcarpenter
deleted the
alexcarpenter/sdki-734-browser-autocomplete-in-signin-and-signup-causes-first-click
branch
November 15, 2024 16:12
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the password field would not render when the email address and password field were autofilled using Google Password Manager which requires no user action to autofill the fields.
Found a workaround in this older thread about autofill behavior issues react/react#1159
Relying solely on the value of the password field was not sufficient enough as documented in the react issue linked above.
Fixes SDKI-734
BEFORE
before.mov
AFTER
after.mov
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Testing
http://localhost:3000/.for testing in site field