Skip to content

fix(clerk-js): Ensure autofill event is triggered during sign-in - #4560

Merged
alexcarpenter merged 6 commits into
mainfrom
alexcarpenter/sdki-734-browser-autocomplete-in-signin-and-signup-causes-first-click
Nov 15, 2024
Merged

fix(clerk-js): Ensure autofill event is triggered during sign-in#4560
alexcarpenter merged 6 commits into
mainfrom
alexcarpenter/sdki-734-browser-autocomplete-in-signin-and-signup-causes-first-click

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Nov 14, 2024

Copy link
Copy Markdown
Member

Description

Fixes an issue where the password field would not render when the email address and password field were autofilled using Google Password Manager which requires no user action to autofill the fields.

Found a workaround in this older thread about autofill behavior issues react/react#1159

Relying solely on the value of the password field was not sufficient enough as documented in the react issue linked above.

Fixes SDKI-734

BEFORE

before.mov

AFTER

after.mov

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Testing

  1. Within Chrome using Google Password Manager, add your username and password
    • Note for localhost use http://localhost:3000/. for testing in site field
  2. Navigate to sign-in page, and see username and password immediately filled
  3. The password field should consistently be rendered

@changeset-bot

changeset-bot Bot commented Nov 14, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09aeb7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter
alexcarpenter marked this pull request as ready for review November 14, 2024 18:49
@alexcarpenter
alexcarpenter merged commit 5bd65aa into main Nov 15, 2024
@alexcarpenter
alexcarpenter deleted the alexcarpenter/sdki-734-browser-autocomplete-in-signin-and-signup-causes-first-click branch November 15, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants