Skip to content

chore(shared): Improve formatting of ClerkRuntimeError message - #4574

Merged
panteliselef merged 4 commits into
mainfrom
elef/sdki-737-improve-formatting-of-clerkruntimeerror-message
Nov 15, 2024
Merged

chore(shared): Improve formatting of ClerkRuntimeError message#4574
panteliselef merged 4 commits into
mainfrom
elef/sdki-737-improve-formatting-of-clerkruntimeerror-message

Conversation

@panteliselef

Copy link
Copy Markdown
Contributor

Description

  • toString() is not guaranteed to be called
  • Always prefix with 🔒 Clerk:
  • Append the error code in the error message, so devs know which error code to check against immediately

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef
panteliselef requested a review from a team November 15, 2024 11:41
@panteliselef panteliselef self-assigned this Nov 15, 2024
@changeset-bot

changeset-bot Bot commented Nov 15, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 39266ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/shared Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef anagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@panteliselef
panteliselef enabled auto-merge (squash) November 15, 2024 13:48
@panteliselef
panteliselef merged commit b28c5e8 into main Nov 15, 2024
@panteliselef
panteliselef deleted the elef/sdki-737-improve-formatting-of-clerkruntimeerror-message branch November 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants