Skip to content

fix(clerk-js): Force ProviderInitialIcon to uppercase - #4578

Merged
alexcarpenter merged 2 commits into
mainfrom
alexcarpenter/provider-initial-casing
Nov 15, 2024
Merged

fix(clerk-js): Force ProviderInitialIcon to uppercase#4578
alexcarpenter merged 2 commits into
mainfrom
alexcarpenter/provider-initial-casing

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

If for some reason a user uses lower case naming for custom provider, force the casing within the <ProviderInitialIcon /> component.

BEFORE AFTER
Screenshot 2024-11-15 at 9 53 51 AM Screenshot 2024-11-15 at 9 53 32 AM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Nov 15, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6827eba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter
alexcarpenter marked this pull request as ready for review November 15, 2024 14:55
@alexcarpenter
alexcarpenter enabled auto-merge (squash) November 15, 2024 15:14
@alexcarpenter
alexcarpenter merged commit 22b7b19 into main Nov 15, 2024
@alexcarpenter
alexcarpenter deleted the alexcarpenter/provider-initial-casing branch November 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants