chore(clerk-js): Exclude _clerk_session_id query param from /waitlist endpoint - #4594
Merged
nikospapcom merged 1 commit intoNov 18, 2024
Conversation
🦋 Changeset detectedLatest commit: d97adc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikospapcom
force-pushed
the
nikospap/user-1052-allow-new-waitlist-entries-when-having-active-session
branch
from
November 18, 2024 12:58
4ae39d3 to
3d81fd9
Compare
nikospapcom
changed the title
_clerk_session_id query param from /waitlist endpoint
nikospapcom
changed the title
_clerk_session_id query param from /waitlist endpoint
nikospapcom
requested review from
anagstef,
brkalow,
nikosdouvlis,
octoper and
panteliselef
November 18, 2024 13:15
nikospapcom
marked this pull request as ready for review
November 18, 2024 13:15
nikospapcom
marked this pull request as draft
November 18, 2024 13:21
nikospapcom
force-pushed
the
nikospap/user-1052-allow-new-waitlist-entries-when-having-active-session
branch
from
November 18, 2024 13:24
3d81fd9 to
6310be9
Compare
kostaspt
reviewed
Nov 18, 2024
nikospapcom
force-pushed
the
nikospap/user-1052-allow-new-waitlist-entries-when-having-active-session
branch
from
November 18, 2024 13:31
6310be9 to
d97adc0
Compare
nikospapcom
marked this pull request as ready for review
November 18, 2024 13:42
anagstef
approved these changes
Nov 18, 2024
panteliselef
approved these changes
Nov 18, 2024
nikospapcom
deleted the
nikospap/user-1052-allow-new-waitlist-entries-when-having-active-session
branch
November 18, 2024 16:48
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We decided to render the
<Waitlist />when a user is logged in but in this case we're sending the_clerk_session_idquery params which is not accepted from thisfapiendpoint. This pr fixes this by excluding_clerk_session_idquery param from/waitlistendpointChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change