chore(clerk-expo-passkeys): fix breaking changes - #4601
Merged
Conversation
🦋 Changeset detectedLatest commit: bb7267f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AlexNti
marked this pull request as ready for review
November 19, 2024 13:55
anagstef
approved these changes
Nov 19, 2024
jacekradko
reviewed
Nov 19, 2024
jacekradko
reviewed
Nov 19, 2024
jacekradko
reviewed
Nov 19, 2024
AlexNti
force-pushed
the
expo-passkeys-fix-after-pnpm
branch
from
November 19, 2024 17:10
3b3b808 to
8193da1
Compare
jacekradko
reviewed
Nov 19, 2024
| settings: { | ||
| 'import/ignore': ['node_modules/react-native/index\\.js$'], | ||
| }, | ||
| rules: { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this commit, we are importing the
Bufferfrombufferinstead ofnode:buffer.We are also moving the
@clerk/expo-passkeysback todevDependenciesat@clerk/clerk-expoChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change