Skip to content

ci(repo): tolerate pnpm warnings in turbo validate step#8624

Open
jacekradko wants to merge 1 commit into
mainfrom
jacek/ci-validate-turbo-strip-warnings
Open

ci(repo): tolerate pnpm warnings in turbo validate step#8624
jacekradko wants to merge 1 commit into
mainfrom
jacek/ci-validate-turbo-strip-warnings

Conversation

@jacekradko
Copy link
Copy Markdown
Member

@jacekradko jacekradko commented May 22, 2026

Two integration shards flaked today on a jq: parse error before any test ran.

The culprit was pnpm turbo run <task> --dry=json having WARN Unsupported engine: wanted node >=24.15.0 (current v20.20.0) prepended to stdout, which broke jq. That warning shows up when useblacksmith/setup-node doesn't successfully swap the runner's Node 20 for Node 24, but the deeper issue is that the preflight assumed pnpm's stdout was pure JSON.

Drops anything before the first { so the validate step survives stray pnpm output, independent of which Node version ends up active on the runner.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 22, 2026

🦋 Changeset detected

Latest commit: 4708a41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 22, 2026 2:37am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR improves the robustness of Turbo task validation in the CI workflow. The integration-tests job's "Validate turbo task" step now captures Turbo --dry=json output into a variable, explicitly checks for validation failures with improved error reporting, and strips non-JSON leading lines (such as warnings) before extracting and validating the .tasks field via jq. A changeset file documents this change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: tolerating pnpm warnings in the turbo validate step, which directly relates to the changeset modifications in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description accurately describes the changeset: it explains the issue with pnpm warnings in turbo output, identifies the problem (jq parse error), and describes the solution (strip output before first '{').

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 22, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8624

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8624

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8624

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8624

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8624

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8624

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8624

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8624

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8624

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8624

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8624

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8624

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8624

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8624

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8624

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8624

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8624

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8624

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8624

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8624

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8624

commit: 4708a41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant