Skip to content

fix(expo): restore iOS Google sign-in default#8905

Merged
wobsoriano merged 1 commit into
mainfrom
mike/revert-ios-google-filter-default
Jun 17, 2026
Merged

fix(expo): restore iOS Google sign-in default#8905
wobsoriano merged 1 commit into
mainfrom
mike/revert-ios-google-filter-default

Conversation

@mikepitre

@mikepitre mikepitre commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Restore the previous iOS Google sign-in default for filterByAuthorizedAccounts.

On iOS, callers must now explicitly pass filterByAuthorizedAccounts: true to enable this behavior.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --filter @clerk/expo test

Summary by CodeRabbit

Bug Fixes

  • Restored iOS Google sign-in default behavior. Sign-in now displays all available accounts instead of filtering to only previously authorized ones. Users can explicitly enable account filtering if needed.

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 13bed67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jun 17, 2026 8:44pm
swingset Ready Ready Preview, Comment Jun 17, 2026 8:44pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The default value for filterByAuthorizedAccounts in the iOS ClerkGoogleSignInModule.swift signIn function is changed from true to false. This restores the previous behavior where sign-in does not filter by previously authorized accounts unless explicitly requested. A patch changeset entry is added for @clerk/expo.

Changes

iOS Google Sign-In Default Behavior Fix

Layer / File(s) Summary
Default parameter change and changeset
packages/expo/ios/ClerkGoogleSignInModule.swift, .changeset/steady-google-signin.md
filterByAuthorizedAccounts default in signIn is set to false instead of true, disabling hint/authorized-account filtering when the caller omits the parameter. Patch changeset documents the restored behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • clerk/javascript#8901: Establishes the hint logic tied to filterByAuthorizedAccounts in ClerkGoogleSignInModule.swift via an Expo Modules refactor — the direct predecessor to this default change.
  • clerk/javascript#8903: Modifies the same filterByAuthorizedAccounts default in ClerkGoogleSignInModule.swift, setting it to true when omitted — the inverse of this PR's change.

Suggested labels

expo

Suggested reviewers

  • wobsoriano

Poem

🐰 A rabbit once hopped through the sign-in gate,
And found old accounts deciding its fate.
"No filtering, please!" it said with a thump,
So false is the default — no authorized bump.
Now every fresh login starts clean from the start! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(expo): restore iOS Google sign-in default' clearly and concisely describes the main change: reverting the default behavior of iOS Google sign-in to its previous state.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8905

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8905

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8905

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8905

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8905

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8905

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8905

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8905

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8905

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8905

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8905

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8905

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8905

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8905

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8905

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8905

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8905

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8905

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8905

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8905

commit: 13bed67

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13bed67ee8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/expo/ios/ClerkGoogleSignInModule.swift
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-17T20:46:01.882Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 13bed67.

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/expo/ios/ClerkGoogleSignInModule.swift`:
- Around line 62-65: The default value for the `filterByAuthorizedAccounts`
parameter has been changed to `false` in ClerkGoogleSignInModule.swift, but the
TypeScript documentation still declares the default as `true`. Update the
`@default` annotation in the JSDoc comment for `filterByAuthorizedAccounts` in
packages/expo/src/google-one-tap/types.ts (lines 36-49) from `@default true` to
`@default false`, and also update the `default: true` in the JSDoc of
packages/expo/src/google-one-tap/ClerkGoogleOneTapSignIn.ts (lines 80-106) to
`default: false` to ensure the public API documentation matches the actual
implementation behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ce05c5b6-4d56-44df-95c6-5db4888fdac8

📥 Commits

Reviewing files that changed from the base of the PR and between 431e16c and 13bed67.

📒 Files selected for processing (2)
  • .changeset/steady-google-signin.md
  • packages/expo/ios/ClerkGoogleSignInModule.swift

Comment thread packages/expo/ios/ClerkGoogleSignInModule.swift
@wobsoriano wobsoriano merged commit 0f1172c into main Jun 17, 2026
53 checks passed
@wobsoriano wobsoriano deleted the mike/revert-ios-google-filter-default branch June 17, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants