fix(expo): restore iOS Google sign-in default#8905
Conversation
🦋 Changeset detectedLatest commit: 13bed67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe default value for ChangesiOS Google Sign-In Default Behavior Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13bed67ee8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/ios/ClerkGoogleSignInModule.swift`:
- Around line 62-65: The default value for the `filterByAuthorizedAccounts`
parameter has been changed to `false` in ClerkGoogleSignInModule.swift, but the
TypeScript documentation still declares the default as `true`. Update the
`@default` annotation in the JSDoc comment for `filterByAuthorizedAccounts` in
packages/expo/src/google-one-tap/types.ts (lines 36-49) from `@default true` to
`@default false`, and also update the `default: true` in the JSDoc of
packages/expo/src/google-one-tap/ClerkGoogleOneTapSignIn.ts (lines 80-106) to
`default: false` to ensure the public API documentation matches the actual
implementation behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: ce05c5b6-4d56-44df-95c6-5db4888fdac8
📒 Files selected for processing (2)
.changeset/steady-google-signin.mdpackages/expo/ios/ClerkGoogleSignInModule.swift
Summary
Restore the previous iOS Google sign-in default for
filterByAuthorizedAccounts.On iOS, callers must now explicitly pass
filterByAuthorizedAccounts: trueto enable this behavior.Testing
Summary by CodeRabbit
Bug Fixes