feat(ui,localizations,shared): condense organization Security page SSO overview#8915
feat(ui,localizations,shared): condense organization Security page SSO overview#8915iagodahlem wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c53fc37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR condenses the OrganizationProfile Security page SSO section from a multi-row detail card (provider, sign-on URL, issuer, role-aware description) to a single summary row showing only domain chips and a one-line description. The localization type contract removes five keys, the ChangesSSO Overview Condensation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
API Changes Report
Summary
@clerk/sharedCurrent version: 4.19.0 Subpath
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
d6b0569 to
a809f30
Compare
…omain row Replace the `ValueChip` wrapper with direct `Badge` rendering for SSO domains and restructure the detail row layout into nested Flex containers with consistent spacing. Move the trailing colon into the `domainLabel` localization string instead of applying it via a `::after` pseudo-element.
ee22fd1 to
c53fc37
Compare
| // Provider, sign-on URL, issuer, and certificate rows are no longer rendered. | ||
| expect(screen.queryByText('Provider')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('Okta Workforce')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('Sign on URL')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('Issuer')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('Certificate')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('CERT')).not.toBeInTheDocument(); | ||
| expect(screen.queryByRole('link', { name: 'https://idp.example.com/sso' })).not.toBeInTheDocument(); | ||
| expect(screen.queryByRole('link', { name: 'https://idp.example.com/entity' })).not.toBeInTheDocument(); |
There was a problem hiding this comment.
I believe it's fine if we drop those assertions here and keep only the assertion for Domains
Description
Condenses the
<OrganizationProfile />Security page SSO overview into a single summary row — a one-line description, the configured domains as chips, and the connection status badge — with all actions under the overflow ("…") menu. Removes the bordered detail card and the Provider, Single sign-on URL, Issuer, and Certificate rows, along with the secondary description line, and drops the now-unusedssoSectionlocalization keys.Implements ORGS-1651. Follow-up to the initial Security page overview (#8813), applying the design review from that PR.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Improvements
Tests