fix(ui): Simple theme checkbox styles#8922
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6c6d9e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughCheckbox appearance is fixed for the simple theme by injecting custom CSS into the ChangesCheckbox Default Styling
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c
📒 Files selected for processing (4)
.changeset/kind-melons-own.mdpackages/ui/src/baseTheme.tspackages/ui/src/elements/FieldControl.tsxpackages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
- packages/ui/src/elements/FieldControl.tsx
Description
Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.
BEFORE
before.mov
AFTER
after.mov
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change