Skip to content

feat(headless): remove renderElement, consolidate into useRender#9233

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/mosaic-use-render-pr3
Jul 23, 2026
Merged

feat(headless): remove renderElement, consolidate into useRender#9233
alexcarpenter merged 2 commits into
mainfrom
carp/mosaic-use-render-pr3

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Stacked on #9232. Merge that first.

Final PR of the renderElementuseRender migration. After PR2, renderElement had zero callers, so this removes it.

What changed

render-element.tsx was doing double duty: it held the dead renderElement function and the shared building blocks every primitive still uses (the prop types + mergeProps). So this is a move-then-delete, not a bare delete:

  • Moved RenderProp, ComponentProps, DefaultProps, StateAttributesMapping, and mergeProps into use-render.tsx (its sole consumer now).
  • Repointed the utils barrel to re-export them from ./use-render. Public barrel surface is unchanged except renderElement is gone (nothing imported it).
  • Deleted render-element.tsx, render-element.test.tsx, render-element.test-d.ts.
  • Ported the mergeProps describe block into use-render.test.tsx and the ComponentProps type test into use-render.test-d.ts so no coverage is lost. The renderElement-specific behavioral tests are dropped with the function (their behavior is already covered by the useRender cases from PR1).

Verification

  • grep renderElement / grep render-element across packages/headless/src + packages/ui/src → zero matches.
  • pnpm --filter @clerk/headless typecheck → clean.
  • pnpm --filter @clerk/headless exec eslint src → exit 0, zero warnings.
  • pnpm --filter @clerk/headless test → 591 passed, 1 skipped.

Empty changeset (@clerk/headless is private).

The two remaining useMergeRefs imports (tooltip-arrow.tsx, popover-arrow.tsx) are correct — those parts render FloatingArrow directly and never used renderElement.

@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jul 23, 2026 11:30pm
swingset Ready Ready Preview, Comment Jul 23, 2026 11:30pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bb86c57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

renderElement has no callers left after the primitive migration. Move the
shared prop types (RenderProp, ComponentProps, DefaultProps,
StateAttributesMapping) and mergeProps into use-render.tsx, repoint the utils
barrel there, and delete render-element.tsx. The mergeProps unit tests and the
ComponentProps type test are ported alongside.
@pkg-pr-new

pkg-pr-new Bot commented Jul 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9233

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9233

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9233

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9233

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9233

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9233

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9233

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9233

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9233

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9233

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9233

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9233

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9233

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9233

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9233

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9233

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9233

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9233

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9233

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9233

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9233

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9233

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9233

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9233

commit: 4c66397

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8accd393-a551-4242-b79a-e3bac6ce853a

📥 Commits

Reviewing files that changed from the base of the PR and between bb86c57 and 4c66397.

📒 Files selected for processing (1)
  • .changeset/curvy-worlds-change.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/clerk-ios (auto-detected)
  • clerk/cli (auto-detected)
  • clerk/clerk-android (auto-detected)

📝 Walkthrough

Walkthrough

The render-related types and mergeProps implementation moved from render-element into use-render. The utility barrel now re-exports these members from use-render, while renderElement is no longer exported. Type tests target use-render, and runtime tests cover prop overrides, event handlers, styles, class names, and refs.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: wobsoriano

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing renderElement and consolidating the shared logic into useRender.
Description check ✅ Passed The description accurately matches the changeset, including the move-delete refactor, deleted tests, and updated barrel exports.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@alexcarpenter
alexcarpenter merged commit 76f1085 into main Jul 23, 2026
49 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-use-render-pr3 branch July 23, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants