Skip to content

fix(ui): suppress passkey autofill RP ID errors - #9687

Merged
jeremy-clerk merged 1 commit into
mainfrom
jeremy/core-3589-firefox-displays-an-error-when-the-passkey-rp-id-is-set-to
Sep 9, 2026
Merged

jeremy-clerk merged 1 commit into
mainfrom
jeremy/core-3589-firefox-displays-an-error-when-the-passkey-rp-id-is-set-to

Conversation

@jeremy-clerk

@jeremy-clerk jeremy-clerk commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Suppress passkey_invalid_rpID_or_domain during background passkey autofill. Firefox rejects conditional requests that require Related Origin Requests even when the authentication-host configuration is valid, which currently surfaces a form error on page load.

The explicit passkey action remains unchanged, which will work fine with RoR requests.

fixes: CORE-3589

Mozilla workaround that causes this error: https://bugzilla.mozilla.org/show_bug.cgi?id=2043449

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ce4f877

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 9, 2026 1:52am UTC
swingset Ready Ready Preview Sep 9, 2026 1:52am UTC

Request Review

@github-actions github-actions Bot added the ui label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: cb5e5617-9d97-4b86-a13c-3237b2840202

📥 Commits

Reviewing files that changed from the base of the PR and between 7731dc3 and ce4f877.

📒 Files selected for processing (3)
  • .changeset/quiet-firefox-passkeys.md
  • packages/ui/src/components/SignIn/__tests__/SignInStart.test.tsx
  • packages/ui/src/components/SignIn/shared.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)

Included review availability: 6 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.


📝 Walkthrough

Walkthrough

The sign-in passkey autofill flow now suppresses passkey_invalid_rpID_or_domain errors in addition to cancelled retrieval errors. Tests verify autofill invocation, error suppression, and continued availability of the “Use passkey instead” action. A patch changeset documents the fix.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ce4f8

Background passkey autofill no longer displays Firefox RP ID or domain errors, while the manual “Use passkey instead” flow remains available. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: suppressing passkey autofill RP ID errors in the UI.
Description check ✅ Passed The description accurately explains the Firefox passkey autofill fix, the preserved explicit passkey behavior, and the related test coverage.

Warning

Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed clerk/clerk_go, clerk/dashboard, clerk/accounts, clerk/backoffice, clerk/clerk, skipped clerk/clerk-docs, clerk/cloudflare-workers.


Comment @coderabbitai help to get the list of available commands.

@jeremy-clerk

Copy link
Copy Markdown
Contributor Author

!snapshot

@pkg-pr-new

pkg-pr-new Bot commented Sep 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9687

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9687

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9687

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9687

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9687

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9687

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9687

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9687

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9687

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9687

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9687

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9687

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9687

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9687

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9687

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9687

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9687

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9687

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9687

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9687

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9687

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9687

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9687

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9687

commit: ce4f877

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-09T01:55:32.536Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on ce4f877.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Hey @jeremy-clerk - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 4.1.1-snapshot.v20260909015433
@clerk/backend 3.17.2-snapshot.v20260909015433
@clerk/chrome-extension 3.1.82-snapshot.v20260909015433
@clerk/clerk-js 6.31.1-snapshot.v20260909015433
@clerk/electron 0.0.42-snapshot.v20260909015433
@clerk/electron-passkeys 0.0.4-snapshot.v20260909015433
@clerk/eslint-plugin 0.2.1-snapshot.v20260909015433
@clerk/expo 4.6.6-snapshot.v20260909015433
@clerk/expo-google-signin 1.0.4-snapshot.v20260909015433
@clerk/expo-passkeys 2.0.18-snapshot.v20260909015433
@clerk/express 2.1.67-snapshot.v20260909015433
@clerk/fastify 3.1.77-snapshot.v20260909015433
@clerk/headless 0.0.32-snapshot.v20260909015433
@clerk/hono 0.1.77-snapshot.v20260909015433
@clerk/localizations 4.16.1-snapshot.v20260909015433
@clerk/msw 0.0.68-snapshot.v20260909015433
@clerk/nextjs 7.9.2-snapshot.v20260909015433
@clerk/nuxt 3.1.1-snapshot.v20260909015433
@clerk/react 6.15.2-snapshot.v20260909015433
@clerk/react-router 3.6.22-snapshot.v20260909015433
@clerk/shared 4.31.1-snapshot.v20260909015433
@clerk/swingset 0.0.45-snapshot.v20260909015433
@clerk/tanstack-react-start 1.5.13-snapshot.v20260909015433
@clerk/testing 2.2.34-snapshot.v20260909015433
@clerk/ui 1.32.3-snapshot.v20260909015433
@clerk/upgrade 2.0.6-snapshot.v20260909015433
@clerk/vue 2.5.1-snapshot.v20260909015433

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@4.1.1-snapshot.v20260909015433 --save-exact

@clerk/backend

npm i @clerk/backend@3.17.2-snapshot.v20260909015433 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@3.1.82-snapshot.v20260909015433 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@6.31.1-snapshot.v20260909015433 --save-exact

@clerk/electron

npm i @clerk/electron@0.0.42-snapshot.v20260909015433 --save-exact

@clerk/electron-passkeys

npm i @clerk/electron-passkeys@0.0.4-snapshot.v20260909015433 --save-exact

@clerk/eslint-plugin

npm i @clerk/eslint-plugin@0.2.1-snapshot.v20260909015433 --save-exact

@clerk/expo

npm i @clerk/expo@4.6.6-snapshot.v20260909015433 --save-exact

@clerk/expo-google-signin

npm i @clerk/expo-google-signin@1.0.4-snapshot.v20260909015433 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@2.0.18-snapshot.v20260909015433 --save-exact

@clerk/express

npm i @clerk/express@2.1.67-snapshot.v20260909015433 --save-exact

@clerk/fastify

npm i @clerk/fastify@3.1.77-snapshot.v20260909015433 --save-exact

@clerk/headless

npm i @clerk/headless@0.0.32-snapshot.v20260909015433 --save-exact

@clerk/hono

npm i @clerk/hono@0.1.77-snapshot.v20260909015433 --save-exact

@clerk/localizations

npm i @clerk/localizations@4.16.1-snapshot.v20260909015433 --save-exact

@clerk/msw

npm i @clerk/msw@0.0.68-snapshot.v20260909015433 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@7.9.2-snapshot.v20260909015433 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@3.1.1-snapshot.v20260909015433 --save-exact

@clerk/react

npm i @clerk/react@6.15.2-snapshot.v20260909015433 --save-exact

@clerk/react-router

npm i @clerk/react-router@3.6.22-snapshot.v20260909015433 --save-exact

@clerk/shared

npm i @clerk/shared@4.31.1-snapshot.v20260909015433 --save-exact

@clerk/swingset

npm i @clerk/swingset@0.0.45-snapshot.v20260909015433 --save-exact

@clerk/tanstack-react-start

npm i @clerk/tanstack-react-start@1.5.13-snapshot.v20260909015433 --save-exact

@clerk/testing

npm i @clerk/testing@2.2.34-snapshot.v20260909015433 --save-exact

@clerk/ui

npm i @clerk/ui@1.32.3-snapshot.v20260909015433 --save-exact

@clerk/upgrade

npm i @clerk/upgrade@2.0.6-snapshot.v20260909015433 --save-exact

@clerk/vue

npm i @clerk/vue@2.5.1-snapshot.v20260909015433 --save-exact

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me

@jeremy-clerk
jeremy-clerk merged commit 5b79f76 into main Sep 9, 2026
59 checks passed
@jeremy-clerk
jeremy-clerk deleted the jeremy/core-3589-firefox-displays-an-error-when-the-passkey-rp-id-is-set-to branch September 9, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants