Remove overly broad require_local_server! label from tests - #5716
Open
joshua-spacetime wants to merge 3 commits into
Open
Remove overly broad require_local_server! label from tests#5716joshua-spacetime wants to merge 3 commits into
require_local_server! label from tests#5716joshua-spacetime wants to merge 3 commits into
Conversation
Shubham8287
approved these changes
Aug 11, 2026
clockwork-labs-bot
enabled auto-merge
August 11, 2026 13:00
bfops
reviewed
Aug 11, 2026
| #[test] | ||
| fn test_servers() { | ||
| // This only covers local CLI config behavior, so it is not valuable to run | ||
| // against remote servers. |
Collaborator
There was a problem hiding this comment.
perhaps we should have a different annotation for these items then? the login and logout related tests above also generally fall into this category.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Nothing in these tests require that they not be run against a replicated cluster.
API and ABI breaking changes
N/A
Expected complexity level and risk
1
Testing
These tests should now be included in the
Internal Testsand they should pass