Remove unused & non-direct declared dependencies for prod - #1187
Merged
Merged
Conversation
Moved: more-itertools, declared in test only, but its imported in prod, moved here. Removed: asn1crypto - it was a dependency of cryptography, but not anymore colorlog - not sure, not used importlib_metadata - no longer needed, we are in python 3.12, nothing uses them anyway importlib_resources zipp - was required by importlib_metadata psutil - Not imported, not used Transitive dependencies: request-file - Via tldextract s3transfer - Via boto3 six - via a bunch of things
marcospri
force-pushed
the
depend-audit-prod
branch
from
September 18, 2026 12:04
4977e9e to
8f24d12
Compare
Contributor
Author
|
gdata is still declared and un-imported but technically is being used (?!) see #316 |
marcospri
marked this pull request as ready for review
September 21, 2026 08:21
wojcikstefan
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved:
more-itertools, declared in test only, but its imported in prod, moved here.
Removed:
asn1crypto - it was a dependency of cryptography, but not anymore
colorlog - not sure, not used
importlib_metadata - no longer needed, we are in python 3.12, nothing uses them anyway
importlib_resources
zipp - was required by importlib_metadata
psutil - Not imported, not used
Transitive dependencies:
request-file - Via tldextract
s3transfer - Via boto3
six - via a bunch of things