Fix Issue 38 and 141#170
Merged
Merged
Conversation
Issue 38 is a documentation change to make the requirement for an `Environment` per thread explicit. Issue 141 is a tiny bug in `tools/gherkinize.py` that generated broken Gherkin from a protobuf test case that didn't have an expected value. The default expected value seems to be Boolean True.
kapilt
reviewed
May 19, 2026
| "pendulum>=3.2.0", | ||
| "pyyaml>=6.0.3", | ||
| "tomli >= 1.1.0 ; python_version < '3.11'", | ||
| "ipykernel>=7.2.0", |
Collaborator
There was a problem hiding this comment.
this one seems odd, and brings in a large dependency stack
Collaborator
Author
There was a problem hiding this comment.
Thank You! Should be in dev -- it's for a notebook to analyze the conformance test cases.
kapilt
approved these changes
May 19, 2026
Collaborator
kapilt
left a comment
kapilt
left a comment
There was a problem hiding this comment.
looks good to me minus the ipython kernel dependency add, which should likely be removed or add to just dev dependencies. i don't see any imports of it anywhere, so looks extraneous.
Move the IPython kernel to the development tools section. (Also, clean up a little of the documentation.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #38 is a documentation change to make the requirement for an
Environmentper thread explicit.Issue #141 is a tiny bug in
tools/gherkinize.pythat generated broken Gherkin from a protobuf test case that didn't have an expected value. The default expected value seems to be Boolean True.This permits rebuilding the features directory to fix the 197 tests with faulty THEN clauses.