Skip to content

Rename gherkinize template and tag config files#176

Merged
slott56 merged 2 commits into
cloud-custodian:mainfrom
CleanFixDev:fix-gherkinize-template-tags-names
May 21, 2026
Merged

Rename gherkinize template and tag config files#176
slott56 merged 2 commits into
cloud-custodian:mainfrom
CleanFixDev:fix-gherkinize-template-tags-names

Conversation

@CleanDev-Fix
Copy link
Copy Markdown
Contributor

Summary

  • rename tools/gherkin.feature.jinja to tools/gherkinize.feature.jinja
  • rename tools/wip.toml to tools/tags.toml
  • update the tool references and docs/notebook references to use the new names

Notes

This keeps the change scoped to the file naming cleanup discussed in #171. The broader JSON/TOML output redesign mentioned in the issue is intentionally left for a separate follow-up.

Testing

.\.venv\Scripts\python.exe -m pytest -q tools
......                                                                   [100%]
6 passed in 0.11s

Fixes #171

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 20, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Nbluff / name: CleanFixDev (2bc1ef3)

@slott56
Copy link
Copy Markdown
Collaborator

slott56 commented May 20, 2026

Very nice. I was hoping to drop the .jinja from the template file so the name had an extension of .feature.

For testing, look at the Makefile. It can run a variety of tests. If you use the bare make command it should provide documentation on all the alternative targets.

@CleanDev-Fix
Copy link
Copy Markdown
Contributor Author

Updated the follow-up requested in review.

Changes:

  • Renamed tools/gherkinize.feature.jinja to tools/gherkinize.feature
  • Updated the Jinja loader reference
  • Updated the tools README reference

Verification:

  • make runs and shows the repo targets.
  • make test-tools passes: 6 passed.
  • make test runs through the Makefile/tox path on Windows, but hits an unrelated platform-specific failure in tests/test_main.py::test_stat_good because os.getegid is not available on Windows. The tools tests covering this change pass locally, and GitHub CI can cover the normal project matrix.

@slott56
Copy link
Copy Markdown
Collaborator

slott56 commented May 21, 2026

Interesting. Custodian never runs in a Windows context, but CEL-Python could be run that way. That's a totally unrelated issue exposed by this. Very helpful.

Copy link
Copy Markdown
Collaborator

@slott56 slott56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding! Very helpful. Very quick, too.

@slott56 slott56 merged commit 81fe387 into cloud-custodian:main May 21, 2026
7 checks passed
@CleanDev-Fix CleanDev-Fix deleted the fix-gherkinize-template-tags-names branch May 21, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename tools/gherkin.feature.jinja

2 participants