Skip to content

Conditional rounded corners#1570

Merged
tylersticka merged 4 commits into
v-nextfrom
feature/simplify-border-radii
Nov 8, 2021
Merged

Conditional rounded corners#1570
tylersticka merged 4 commits into
v-nextfrom
feature/simplify-border-radii

Conversation

@tylersticka

Copy link
Copy Markdown
Member

Overview

This PR adds a mixin for Ahmad Shadeed's conditional border radius technique, and applies that technique to various elements:

  • Code blocks now have rounded corners above full-width by default. This will appear more consistent with other block elements like groups and cards.
  • Alerts no longer require a full-width modifier. (I don't consider this a breaking change because the existing options have no effect.)
  • Contained cards no longer require border radii negation. This removes the need to include complicated border-radius rules in the otherwise layout-focused container object.
  • Gutenberg styles for pull quotes, backgrounds and groups have been significantly streamlined.

Screenshots

border-radius-conditional


@changeset-bot

changeset-bot Bot commented Nov 5, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ced56a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Nov 5, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for cloudfour-patterns ready!

🔨 Explore the source changes: ced56a3

🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/6185ae2522bc1e0007f8b37c

😎 Browse the preview: https://deploy-preview-1570--cloudfour-patterns.netlify.app

@tylersticka
tylersticka marked this pull request as ready for review November 5, 2021 22:41
@tylersticka
tylersticka requested review from a team November 5, 2021 22:41

@Paul-Hebert Paul-Hebert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super neat 👍

@tylersticka
tylersticka merged commit ba905bf into v-next Nov 8, 2021
@tylersticka
tylersticka deleted the feature/simplify-border-radii branch November 8, 2021 17:40
@github-actions github-actions Bot mentioned this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify rounded corner negation

2 participants