Alert component: Add role, id, and hidden attributes#1914
Merged
Conversation
🦋 Changeset detectedLatest commit: d52be19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gerardo-rodriguez
changed the title
id and hidden attributes
gerardo-rodriguez
changed the title
id and hidden attributesid and hidden attributes
gerardo-rodriguez
marked this pull request as ready for review
July 7, 2022 00:16
tylersticka
reviewed
Jul 7, 2022
Member
Author
|
@cloudfour/dev I've addressed PR feedback. Ready for another review! 😄 |
calebeby
reviewed
Jul 7, 2022
gerardo-rodriguez
changed the title
id and hidden attributesrole, id, and hidden` attributes
gerardo-rodriguez
changed the title
role, id, and hidden` attributesrole, id, and hidden attributes
Member
Author
|
@cloudfour/dev PR has been updated based on the latest round of feedback, thank you! 👍🏽 |
calebeby
reviewed
Jul 7, 2022
Co-authored-by: Caleb Eby <calebeby@users.noreply.github.com>
calebeby
approved these changes
Jul 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the Alert component:
role,id, andhiddenattributesScreenshots
Testing
role,idandhiddenattribute can be addedidandhiddenattributes to be set #1915