Skip to content

Remove button swap JS#1917

Merged
calebeby merged 3 commits into
v-nextfrom
rm-button-swap-js
Jul 7, 2022
Merged

Remove button swap JS#1917
calebeby merged 3 commits into
v-nextfrom
rm-button-swap-js

Conversation

@calebeby

@calebeby calebeby commented Jul 7, 2022

Copy link
Copy Markdown
Member

Closes #1899

@changeset-bot

changeset-bot Bot commented Jul 7, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bc9fdb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jul 7, 2022

Copy link
Copy Markdown

Deploy Preview for cloudfour-patterns ready!

Name Link
🔨 Latest commit bc9fdb0
🔍 Latest deploy log https://app.netlify.com/sites/cloudfour-patterns/deploys/62c71f49d8aada0008395a2f
😎 Deploy Preview https://deploy-preview-1917--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@calebeby

calebeby commented Jul 7, 2022

Copy link
Copy Markdown
Member Author

@gerardo-rodriguez In making this change I realized that when we reimplemented this on the WP side, we did not reimplement the visually hidden status message functionality that was in the button-swap JS. Is that something we should reimplement on the WP side?

@calebeby
calebeby requested a review from a team July 7, 2022 18:00
@gerardo-rodriguez

Copy link
Copy Markdown
Member

@gerardo-rodriguez In making this change I realized that when we reimplemented this on the WP side, we did not reimplement the visually hidden status message functionality that was in the button-swap JS. Is that something we should reimplement on the WP side?

@calebeby Good catch! Maybe? I'm trying to get the push notifications to work in Safari on my local and I can't I wanted to see what the UX was like. 🤔

@gerardo-rodriguez

Copy link
Copy Markdown
Member

@gerardo-rodriguez In making this change I realized that when we reimplemented this on the WP side, we did not reimplement the visually hidden status message functionality that was in the button-swap JS. Is that something we should reimplement on the WP side?

@calebeby Good catch! Maybe? I'm trying to get the push notifications to work in Safari on my local and I can't I wanted to see what the UX was like. 🤔

@calebeby Can you add a GH issue to follow up on your question? I can't get Safari to work locally or in production. I wonder if something is up with OneSignal + Safari? 🤔

@calebeby
calebeby merged commit 4e8ef04 into v-next Jul 7, 2022
@calebeby
calebeby deleted the rm-button-swap-js branch July 7, 2022 20:01
@github-actions github-actions Bot mentioned this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Button Swap JS

2 participants