Fix spacing utility demos#662
Conversation
…r logical properties, still WIP
…al properties. Appears there may be a bug in this module
|
@tylersticka and @calebeby: I am putting this out for review having completely removed If in the future we were to add this back, demo markup and CSS would need to be revised to add The logical-properties plugin did not seem to be converting all values correctly, particularly for the TBH, I get pretty confused by some of the combinations, particularly with vertical writing modes, but I think the examples in If there's a feeling we should be keeping Please let me know if you have any questions about this update. Thanks |
|
Others are welcome to review, but please don't merge until I've had a chance to. Thank you! |
|
@tylersticka, ready for re-review. Thanks |
|
@tylersticka, thanks for the feedback. Updated and |
| * Ideally we could use the *-inline shorthand, but it is not as well | ||
| * supported in browsers. | ||
| */ |
There was a problem hiding this comment.
Nit: We usually align the first asterisks (not the second), like jsdoc.
There was a problem hiding this comment.
I tried that and the linter changed it. I'll try again.
There was a problem hiding this comment.
No idea why, but this time I reverted it to the way I had it and the linter didn't complain, so updated.
There was a problem hiding this comment.
@tylersticka, whenever you have a moment ^
* v-next: Fix spacing utility demos (#662)
Overview
-startand-endcombinations, to fix issues across supported browsers.postcss-preset-envwith postcss-logical was unable to solve these issues and introduced othersScreenshots
Utilities -> Spacing -> Padding demo, PR 651:
Same demo, this PR (note
.u-pad-block-1and.u-pad-inline-1):Testing
postcss-preset-env.u-pad-inline-1,.u-pad-block-1,.u-space-pad-1, and.u-space-block-1) all look correct in the previews for this PR/CC @person