[pull] master from mozilla:master - #545
Merged
Merged
Conversation
The existing methods are only used as a fallback in non-Firefox browsers that lack support for the Font Loading API, and this is also very old code. By combining this functionality into just a single (private) method, we ever so slight reduce the size of this code in the MOZCENTRAL build.
…egration tests This reduces the amount of code needed for the checks, and thereby makes the intent of the assertions clearer.
…pe.bind` method After the previous commit throwing an Error now results is (slightly) more code than keeping the `#testFontLoaded` call intact, and note that that method itself already throws in MOZCENTRAL builds. Also, fix a typo in an error message thrown in WORKER_THREAD builds.
…lert Use the `waitForTextToBe` helper function in the editor alert bar integration tests
Re-factor the test-font fallback loading in the `FontLoader` class
Use the `waitForTextToBe` helper function in the remaining integration tests
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )