[pull] master from mozilla:master - #547
Merged
Merged
Conversation
At this point in time there's only a single `getMap` call-site in the entire code-base, and the preceding check guarantees that it cannot be an `IdentityCMap` instance; note https://github.com/mozilla/pdf.js/blob/5d7f2ba0f39826c1ac14dc1ae9e970920cc6dfeb/src/core/evaluator.js#L4043-L4046
…achable Mark `IdentityCMap.prototype.getMap` as unreachable
Set the ClearType level to 0 and the rendering mode to natural symmetric (5). When Windows ClearType is enabled, Firefox applies these overrides and selects grayscale instead of subpixel antialiasing by default. The FreeText position tests located the glyphs by binarizing the screenshots at 50% luminance and taking the first black pixel: with antialiasing a thin stem can be split over two light pixels and then disappears, so the detected position jumps to the next stem. Use the centroid of the ink instead, which doesn't depend on any threshold.
Use grayscale text antialiasing in Windows Firefox tests
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )