[pull] main from Milkdown:main#229
Merged
Merged
Conversation
* build: upgrade to typescript 7 native compiler - bump typescript ^6.0.0 -> ^7.0.0 (native tsc); the existing `tsc -b` still does type-check + .d.ts emit, bundlers still emit JS - drop rollup-plugin-dts: it relies on the classic TS JS compiler API which is removed in TS7. prose .d.ts are now produced by `tsc -b` (its exports already map 1:1 to lib/<name>.d.ts) - remove an unused type parameter on CommandManager.remove's string overload, newly flagged by the native compiler (TS6196) * build: add docs -> @milkdown/dev project reference for tsc build order docs imports @milkdown/dev, whose exports resolve types to lib/*.d.ts, so dev must be built before docs. docs only had @milkdown/dev as a devDependency, which the tsconfig generator ignores, so docs/tsconfig had no reference to dev. Under TS6 the tsc -b scheduler happened to build dev first; the native TS7 scheduler builds docs first on a clean tree and fails with TS2307. Move @milkdown/dev to dependencies so codegen emits the docs -> dev reference and the build order is guaranteed.
Resolve deferred list item block cursor positions during the animation frame. Keep the generated selection tied to the same current document as the transaction. Co-authored-by: Zero <zero@vm0.ai>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )