[pull] canary from vercel:canary - #1393
Merged
Merged
Conversation
### What? Run all `turbo-tasks-macros-tests` trybuild fixture groups through one test process and one generated Cargo project lifecycle. ### Why? Trybuild uses one generated Cargo project per package. Cargo-nextest previously launched the five test groups as separate processes, allowing them to overwrite that project's manifest while another group was compiling. On canary this surfaced as diagnostics from the wrong fixture, missing `trybuild00N` bin targets, and compile-fail cases incorrectly succeeding. The tracked stderr snapshots are correct; the instability is in concurrent harness execution rather than compiler output or the SWC version. ### How? A single `TestCases` instance now queues every existing pass and compile-fail glob. This preserves per-fixture diagnostics and coverage while preventing cross-process manifest collisions. A comment documents the shared-project invariant so the groups are not split into concurrent tests again. ### Verification - `cargo nextest run -p turbo-tasks-macros-tests --cargo-profile release-with-assertions --no-fail-fast` - `cargo fmt --all -- --check` - `git diff --check` <!-- NEXT_JS_LLM --> <!-- fleet ae1d9ec9-156e-4b53-80c0-f24bf0b22f13 --> Co-authored-by: vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )