[pull] canary from vercel:canary - #1396
Merged
Merged
Conversation
## Summary Add `NEXT_DEV_WAIT_FOR_TURBOPACK_SHUTDOWN` to make `next dev` wait for Turbopack's full project shutdown before exiting. This waits for active TurboTasks work and cache persistence instead of relying on fixed delays or the parent's normal 100 ms child-exit timeout. Use the option in the warm-restart task statistics test. Link documented `Project` interface methods to their native binding documentation. ## Verification - `pnpm --filter=next types` - `npx eslint --config eslint.config.mjs packages/next/src/cli/next-dev.ts packages/next/src/server/dev/hot-reloader-turbopack.ts test/e2e/filesystem-cache/warm-restart-task-stats.test.ts` - Pre-commit lint-staged checks - CI tests passed <!-- NEXT_JS_LLM -->
## Summary Replace top-level consistency suppression in straightforward backend tests with local operation roots that are read strongly consistently. Inner operation functions keep each migration scoped to its test. ## Verification - `cargo test -p turbo-tasks-backend --test filter_unused_args --test panics --test task_statistics` - `cargo fmt --all -- --check` <!-- NEXT_JS_LLM --> <!-- fleet 475180cd-06a7-4669-89b5-a2029a3a18c9 --> --------- Co-authored-by: vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by: Luke Sandberg <210140+lukesandberg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )