Skip to content

fix: Crash when using xScenario & Scenario.skip with tag - #1792

Merged
DavertMik merged 1 commit into
codeceptjs:masterfrom
VikalpP:fix-xScenario
Jul 24, 2019
Merged

fix: Crash when using xScenario & Scenario.skip with tag#1792
DavertMik merged 1 commit into
codeceptjs:masterfrom
VikalpP:fix-xScenario

Conversation

@VikalpP

@VikalpP VikalpP commented Jul 20, 2019

Copy link
Copy Markdown
Collaborator

By returning the object of Scenario it continues to support other methods provided by Scenario.

resolves #1751

@VikalpP

VikalpP commented Jul 20, 2019

Copy link
Copy Markdown
Collaborator Author

Fix of failing test is #1768.
So, this PR depends on it.

@VikalpP VikalpP changed the title fix: return actual Scenario obejct for xScenario & Scenario.skip fix: Crash when using xScenario & Scenario.skip with tag Jul 21, 2019
@DavertMik

Copy link
Copy Markdown
Contributor

Thanks!

@DavertMik
DavertMik merged commit 51e8aef into codeceptjs:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when using xScenario with tag

2 participants