Release 2.4 - #2129
Merged
Merged
Conversation
DavertMik
commented
Jan 10, 2020
| package-lock.json | ||
| yarn.lock | ||
| /.vs | ||
| typings/types.d.ts No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
I added this to ignore conflicts in our PRs
Contributor
There was a problem hiding this comment.
Should types.d.ts be deleted?
Contributor
Author
There was a problem hiding this comment.
Probably not, to accidentally not to release a package without types.
Contributor
There was a problem hiding this comment.
And types will stay outdated in code
Contributor
Author
There was a problem hiding this comment.
Ah, you mean remove from git? Ok
Vorobeyko
suggested changes
Jan 10, 2020
Vorobeyko
previously approved these changes
Jan 10, 2020
pablopaul
reviewed
Jan 10, 2020
| Every Scenario inside this feature will be rerun 3 times. | ||
| You can make an exception for a specific scenario by passing the `retries` option to a Scenario. | ||
|
|
||
| ### Rerunning Flaky Tests Multiple Times |
Collaborator
There was a problem hiding this comment.
@DavertMik I would remove "Rerunning Flaky Tests Multiple Times" from "basics.md" and just leave it in "advanced.md", currently it seems to be duplicated to me
Contributor
Author
There was a problem hiding this comment.
Yeah, I put this twice but this is not basics information
pablopaul
previously approved these changes
Jan 10, 2020
elukoyanov
reviewed
Jan 10, 2020
|
|
||
|
|
||
| ### Screenshot on Failure | ||
| ### Screenshot on Failure <Badge text="Enabled by default"/> |
Contributor
There was a problem hiding this comment.
Do we need to add this badge to all enabled by default plugins?
What about disabled?
Contributor
Author
There was a problem hiding this comment.
Removed the badge
|
|
||
| You can auto-retry a failed step by enabling [retryFailedStep Plugin](/plugins/#retryfailedstep). | ||
|
|
||
| > **autoRetry plugin is enabled by default** for new setups since CodeceptJS 2.4 |
Contributor
There was a problem hiding this comment.
Why this differs from 463, 453 rows?
Do we need badges or quoted messages?
Contributor
Author
There was a problem hiding this comment.
Yeah, added quotes
| * `Scenario.only` - executes only the current test | ||
|
|
||
| ## Todo test | ||
| ## Todo |
Contributor
There was a problem hiding this comment.
Why Todo test was removed?
IMO, Todo looks like we forgot to add docs :)
How about Not implemented tests (todo)
| ... | ||
| rerun: { | ||
| //how many times all tests in suite must pass | ||
| // inside to codecept.conf.js |
Contributor
There was a problem hiding this comment.
"inside to" ?
maybe simple "inside"?
| package-lock.json | ||
| yarn.lock | ||
| /.vs | ||
| typings/types.d.ts No newline at end of file |
Contributor
There was a problem hiding this comment.
Should types.d.ts be deleted?
kobenguyent
previously approved these changes
Jan 10, 2020
| * Detect flaky tests in our suite | ||
| * Fix flaky tests by rerunning them. | ||
|
|
||
| Both tasks can be achieved with [`run-rerun` command](commands/#run-multiple) which runs tests multiple times until all tests are passed. |
Collaborator
There was a problem hiding this comment.
This refers run-multiple?
elukoyanov
reviewed
Jan 10, 2020
4 tasks
kobenguyent
reviewed
Jan 10, 2020
| "puppeteer", | ||
| "webdriver", | ||
| "testcafe", | ||
| "protractor", |
Collaborator
There was a problem hiding this comment.
how about adding api tests cause we also support it.
DavertMik
dismissed stale reviews from kobenguyent, pablopaul, and Vorobeyko
via
January 10, 2020 12:07
eabde97
|
🌀 Tests overview by Testomatio Found 839 mocha tests in 69 files ✔️ Added 1 tests+ run-rerun command: should display error if minSuccess more than maxReruns🗑️ Removed 1 tests- run-rerun command: should display error if minSuccess more then maxReruns
|
Contributor
Author
|
Complexity increasing per file
==============================
- lib/rerun.js 4
Clones added
============
- lib/rerun.js 1
See the complete overview on Codacy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Webdriver
Puppeteer
Nightmare
REST
Appium
Protractor
TestCafe
Description of this PR, which problem it solves
A link to the corresponding issue (if applicable).
Type of change
Checklist:
npm run docs)npm run lint)npm test)