Skip to content

Fix: Fail "helper.saveScreenshot is not a function" on stepByStepReport plugin #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavertMik merged 1 commit into from
Dec 18, 2020
Merged

Fix: Fail "helper.saveScreenshot is not a function" on stepByStepReport plugin #2688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/plugin/autoDelay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const store = require('../store');
const recorder = require('../recorder');
const event = require('../event');
const log = require('../output').log;
const supportedHelpers = require('./standardActingHelpers');
const supportedHelpers = require('./standardActingHelpers').slice();

@elukoyanov elukoyanov Nov 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about modern spread operator usage? `supportedHelpers = [...require('./standardActingHelpers')]?

@andrerleao andrerleao Nov 22, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elukoyanov,

Because I don't know much about Node Js, I tried to fix the problem as simply as possible.

@DavertMik DavertMik Dec 18, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is fine as well

@DavertMik DavertMik Dec 18, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously this slice was there, not sure why it was removed


const methodsToDelay = [
'click',
Expand Down