Skip to content

#2797 +CustomLocators interface - #2798

Merged
DavertMik merged 2 commits into
codeceptjs:3.xfrom
danielrentz:issue2797
Feb 5, 2021
Merged

#2797 +CustomLocators interface#2798
DavertMik merged 2 commits into
codeceptjs:3.xfrom
danielrentz:issue2797

Conversation

@danielrentz

Copy link
Copy Markdown
Contributor

Motivation/Description of the PR

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • puppeteerCoverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • wdio

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@DavertMik

Copy link
Copy Markdown
Contributor

@danielrentz thanks!
do you think this change should be documented in https://github.com/codeceptjs/CodeceptJS/blob/3.x/docs/typescript.md ?

@danielrentz

Copy link
Copy Markdown
Contributor Author

@danielrentz thanks!
do you think this change should be documented in https://github.com/codeceptjs/CodeceptJS/blob/3.x/docs/typescript.md ?

Sure, I will do so.

@danielrentz

Copy link
Copy Markdown
Contributor Author

@DavertMik Done!

@DavertMik

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript: No way to extend the LocatorOrString type for custom locators

2 participants