Skip to content

fix: screenshot error in beforeSuite/AfterSuite - #4385

Merged
kobenguyent merged 2 commits into
3.xfrom
fix/screenshot-error-with-beforesuite-aftersuite
Jun 8, 2024
Merged

fix: screenshot error in beforeSuite/AfterSuite#4385
kobenguyent merged 2 commits into
3.xfrom
fix/screenshot-error-with-beforesuite-aftersuite

Conversation

@kobenguyent

@kobenguyent kobenguyent commented Jun 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Motivation/Description of the PR

  • fix: screenshot error in beforeSuite/AfterSuite
  • fix one more scenario
     Cannot read properties of undefined (reading 'toString')
      at persistStep (node_modules/codeceptjs/lib/plugin/stepByStepReport.js:148:63)
      at /Users/t/Desktop/projects/codeceptjs-playwright-fun/node_modules/codeceptjs/lib/plugin/stepByStepReport.js:105:59
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

Applicable plugins:

  • screenshotOnFail
  • stepByStepReport

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
kobenguyent merged commit 1040494 into 3.x Jun 8, 2024
@kobenguyent
kobenguyent deleted the fix/screenshot-error-with-beforesuite-aftersuite branch June 8, 2024 04:56
@kobenguyent kobenguyent mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 21, 2024
Closed
Closed
@ThomasSanson ThomasSanson mentioned this pull request Dec 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kobenguyent