Skip to content

Skip sync-drift for agents without a sync capability (#100) - #103

Merged
AntoineToussaint merged 1 commit into
mainfrom
issue-100-sync-drift-skip-agents-that-do-not-advertise
Jul 23, 2026
Merged

Skip sync-drift for agents without a sync capability (#100)#103
AntoineToussaint merged 1 commit into
mainfrom
issue-100-sync-drift-skip-agents-that-do-not-advertise

Conversation

@AntoineToussaint

@AntoineToussaint AntoineToussaint commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

User description

Closes #100.

Summary

  • Runtime-only agents (redis, s3, postgres, vault) advertise only BUILDER/RUNTIME with no validation: block. A module-level input change marks every service in the module affected, so sync-drift then ran for these infra services and hard-errored — even though they own no generated source that could drift.
  • Builder.Sync dry-run now skips (reports skipped, not failed) when the agent advertises no sync capability, keeping a hard error only for the advertised && !supported case. This matches the audit/sbom guard and the compatibility-mode behavior already documented in docs/design/codefly-native-ci.md.
  • The CI report surfaces the skip as a genuine skipped task (reason agent_no_sync_capability) rather than a silent pass.

Test plan

  • go test ./pkg/orchestration/ — new Builder.Sync unit tests cover skip (no contract) and hard-error (advertised-but-unsupported) paths.
  • go test ./cmd/ci/ — new report test asserts a running task marked skipped survives finishTask(nil) and is summarized as skipped, not passed.
  • go build ./... and go vet ./pkg/orchestration/ ./cmd/ci/.

🤖 Generated with Claude Code


CodeAnt-AI Description

Skip sync drift checks for agents that do not support sync

What Changed

  • Dry-run sync drift now skips services whose agents do not advertise sync support, instead of failing the CI run
  • These skipped checks are recorded as skipped tasks with a clear reason, so the report shows why sync drift was not run
  • Agents that claim sync support but do not actually support it still fail as before

Impact

✅ Fewer false CI failures on infra services
✅ Clearer sync drift reports
✅ Safer handling of agents without generated source

🔄 Retrigger CodeAnt AI Review

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Runtime-only agents (redis, s3, postgres, vault) advertise BUILDER/RUNTIME
with no validation contract. The sync-drift dry-run branch hard-errored on
any such agent, so a module-level input change — which marks every service
in the module affected — failed the gate on infra services that own no
generated source to drift.

Align the dry-run guard with the audit/sbom pattern and the documented
compatibility mode: a missing sync capability now reports the task as
skipped rather than failed, while an agent that advertises sync but reports
it unsupported still hard-errors.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@slopbuster

slopbuster Bot commented Jul 23, 2026

Copy link
Copy Markdown

💳 Subscription Required

codefly-dev has used all free reviews this month.

Subscribe to continue

@codeant-ai

codeant-ai Bot commented Jul 23, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR cae0252 Jul 23, 2026 · 15:20 15:25

Updated in place by CodeAnt AI · last 5 reviews

@codeant-ai codeant-ai Bot added the size:L This PR changes 100-499 lines, ignoring generated files label Jul 23, 2026
@AntoineToussaint
AntoineToussaint merged commit 5e071ca into main Jul 23, 2026
1 check passed
@AntoineToussaint
AntoineToussaint deleted the issue-100-sync-drift-skip-agents-that-do-not-advertise branch July 23, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sync-drift: skip agents that do not advertise the sync capability (currently hard-errors)

1 participant