Skip sync-drift for agents without a sync capability (#100) - #103
Merged
AntoineToussaint merged 1 commit intoJul 23, 2026
Merged
Conversation
Runtime-only agents (redis, s3, postgres, vault) advertise BUILDER/RUNTIME with no validation contract. The sync-drift dry-run branch hard-errored on any such agent, so a module-level input change — which marks every service in the module affected — failed the gate on infra services that own no generated source to drift. Align the dry-run guard with the audit/sbom pattern and the documented compatibility mode: a missing sync capability now reports the task as skipped rather than failed, while an agent that advertises sync but reports it unsupported still hard-errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
💳 Subscription Requiredcodefly-dev has used all free reviews this month. |
🤖 CodeAnt AI — Review Status
Updated in place by CodeAnt AI · last 5 reviews |
AntoineToussaint
deleted the
issue-100-sync-drift-skip-agents-that-do-not-advertise
branch
July 23, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Closes #100.
Summary
redis,s3,postgres,vault) advertise onlyBUILDER/RUNTIMEwith novalidation:block. A module-level input change marks every service in the module affected, so sync-drift then ran for these infra services and hard-errored — even though they own no generated source that could drift.Builder.Syncdry-run now skips (reports skipped, not failed) when the agent advertises nosynccapability, keeping a hard error only for theadvertised && !supportedcase. This matches theaudit/sbomguard and the compatibility-mode behavior already documented indocs/design/codefly-native-ci.md.skippedtask (reasonagent_no_sync_capability) rather than a silent pass.Test plan
go test ./pkg/orchestration/— newBuilder.Syncunit tests cover skip (no contract) and hard-error (advertised-but-unsupported) paths.go test ./cmd/ci/— new report test asserts a running task marked skipped survivesfinishTask(nil)and is summarized as skipped, not passed.go build ./...andgo vet ./pkg/orchestration/ ./cmd/ci/.🤖 Generated with Claude Code
CodeAnt-AI Description
Skip sync drift checks for agents that do not support sync
What Changed
Impact
✅ Fewer false CI failures on infra services✅ Clearer sync drift reports✅ Safer handling of agents without generated source🔄 Retrigger CodeAnt AI Review
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.