Complete promotable GitOps publication (#156) - #157
Merged
AntoineToussaint merged 3 commits intoJul 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156.
Summary
Test plan
go test ./... -count=1go test -race ./... -count=1go vet ./...golangci-lint run --tests=false --new-from-rev=origin/main ./...using a temporary v2-migrated copy of the checked-in v1 config (0 changed-code issues)CODEFLY_GITOPS_K3D_QUALIFY=1 go test ./pkg/gitops -run ^TestLocalK3dDisposableGitQualification -v -count=1 -timeout=12mThe installed golangci-lint v2 cannot load the repository's checked-in v1 config directly; a repository-wide run with the migrated config reports 276 pre-existing findings, while the changed production code is clean.
Risk
Publication creates or fast-forwards
codefly/snapshot-<module>-<environment>before module generation so Argo fetches the exact reviewed SHA. If generation fails, that immutable snapshot remains available for a safe retry; publication never force-pushes it.