fix(gateway): avoid duplicating typed status message in output (#254) - #279
Open
AntoineToussaint wants to merge 1 commit into
Open
fix(gateway): avoid duplicating typed status message in output (#254)#279AntoineToussaint wants to merge 1 commit into
AntoineToussaint wants to merge 1 commit into
Conversation
Build and Lint unconditionally prepended the typed runtime status message to the raw agent output. Agents that already fold the actionable message into raw output (as Generic does) then surfaced it twice. Compose via composeStatusOutput, which only prepends the status message when the raw output does not already carry it, generically for all agents. Distinct status context and native output are preserved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #254.
Summary
BuildandLintunconditionally prepended the typed runtime status message to raw agent output, so agents that already fold the actionable message into raw output (like Generic 0.0.16) surfaced it twice.composeStatusOutputhelper that only prepends the status message when the raw output does not already carry it — generically for all agents, no Generic special-casing. Distinct status context and native output are preserved when they differ.Test plan
go test ./pkg/gateway/passesTestBuildDoesNotDuplicateStatusMessageInOutput,TestLintDoesNotDuplicateStatusMessageInOutput(identical status/output collapses to one copy), andTestBuildPrependsDistinctStatusMessage(distinct message still prepended)🤖 Generated with Claude Code