Gate releases on base-manifest freshness (#75) - #76
Merged
AntoineToussaint merged 2 commits intoJul 31, 2026
Conversation
The base-integrity `check` command trusts the committed manifest as its source of truth, so a base file edited without re-running `gen` ships a stale digest that `check` cannot detect — v0.0.32 shipped stale hashes for deployment_topology.go and network-policy.golden.yaml, aborting every consumer sync with an unreconcilable source-path mismatch. Add a `verify` command that re-derives the manifest from the canonical tree and fails on any changed, unrecorded, or removed base file, and run it in provider CI so the canonical artifact can never ship out of sync again. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
baseManifestFreshnessErrors compared only the files map, but the artifact
gen writes is {note, fileCount, files}. A manifest with a drifted fileCount
or note passed verify while gen would still rewrite it, breaking the "gen is
a no-op" guarantee the gate exists to prove. Compare every field gen emits.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
AntoineToussaint
deleted the
issue-75-v0-0-32-ships-a-stale-base-manifest
branch
July 31, 2026 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75.
Summary
base-integrity.mjs checktrusts the committedbase-manifest.jsonas its source of truth, so it re-hashes only the paths already recorded. A base file edited without re-runninggenships a stale digest thatcheckstructurally cannot catch — this is why the v0.0.32 release passed while shipping stale hashes fordeployment_topology.goandnetwork-policy.golden.yaml, blocking every consumer sync.verifycommand that re-derives the manifest from the canonical tree and fails on any changed, unrecorded, or removed base file, and runs it (plus the guard's unit tests) in a dedicated provider-CI job so the canonical artifact can never ship out of sync again.mainwas already fresh; the only manifest-hash changes here are for the twotools/files this PR edits.Notes
main, so it cannot be retro-fixed from here — this PR fixes the recurrence gap (issue suggested-fix accounts+frontend: user/team/session CRUD, RLS-scope fixes, settings #2) so the next release is gated.RELEASE_GATES.mddocuments why this one gate lives in provider YAML.69c4cb10…fordeployment_topology.gowhile the file atv0.0.32hashes tobcc36469…; a fresh regeneration diverges there, soverifywould have failed that release.Test plan
node module/tools/base-integrity.mjs verify→ passes on a fresh tree, exits non-zero listing the drift when a base file changes without regeneration.node --test module/tools/base-integrity.test.mjs→ 19 pass, including a canonical-manifest-matches-tree assertion and a fixture covering stale/unrecorded/removed entries.node module/tools/base-integrity.mjs checkstill green (0 modified, 0 missing, 0 side-additions).node module/tools/base-integrity.mjs genis a no-op on the committed manifest.