Add transport-boundary conformance tests (#22) - #39
Merged
AntoineToussaint merged 1 commit intoJul 30, 2026
Merged
Conversation
Lock in the manifest-only boundary that is enforceable today: neither the deployment templates nor the rendered restricted tree carry reconciliation control-plane objects or repository source bindings, and runtime source links no Git/GitHub/Argo/Flux client, shells out to no git/gh CLI, and embeds no GitHub API endpoint. The source check parses the Go AST so a forbidden term in a comment or doc string is not mistaken for real integration, while os/exec shell-outs and endpoint literals that a bare import denylist would miss are still caught. The detector is covered directly by table tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
AntoineToussaint
force-pushed
the
issue-22-adopt-the-transport-neutral-kubernetes-manifest-bundle
branch
from
July 30, 2026 09:05
14ff10a to
768c187
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
Summary
v0.2.52still shipsKUBERNETES_OUTPUT_PROFILE_PROMOTABLE_GITOPS_V1and theGitOpstemplating flag). Renaming against a neutral enum that does not exist yet would not compile, so that rename is deferred to when core#110 lands. The shared conformance workflow (.github#3) and the promotion driver (cli#160) are likewise still open, so no reusable workflow or external consumer exists to wire up.go test ./..., so the new checks run on every push without a bespoke job.What this does not do (blocked)
PROMOTABLE_GITOPS_V1→ neutral restricted/portable profile (needs core#110).Test plan
go test .—TestDeploymentTemplatesCarryNoTransportBindings,TestRestrictedRenderCarriesNoTransportBindings,TestRuntimeSourceHasNoReconcilerIntegrationpass.go vet .andgo build ./...clean.🤖 Generated with Claude Code