Skip to content

Testing output buffer not closed #1230

Description

@jim-parry

A change was made at some point over the last few months, which results in some tests being flagged as "risky". The travis-ci builds, but the risky tests mess up code coverage.

CodeIgniter 4 version
develop

Affected module(s)
Travis-ci log excerpt:

  1. CodeIgniter\CodeIgniterTest::testRunDefaultRoute
    Test code or tested code did not (only) close its own output buffers
  2. CodeIgniter\CodeIgniterTest::testRunEmptyDefaultRoute
    Test code or tested code did not (only) close its own output buffers
  3. CodeIgniter\CodeIgniterTest::testRun404Override
    Test code or tested code did not (only) close its own output buffers
  4. CodeIgniter\CodeIgniterTest::testControllersCanReturnString
    Test code or tested code did not (only) close its own output buffers
  5. CodeIgniter\CodeIgniterTest::testControllersCanReturnResponseObject
    Test code or tested code did not (only) close its own output buffers
  6. CodeIgniter\CodeIgniterTest::testRoutesIsEmpty
    Test code or tested code did not (only) close its own output buffers
  7. CodeIgniter\CodeIgniterTest::testTransfersCorrectHTTPVersion
    Test code or tested code did not (only) close its own output buffers
  8. FeatureTestCaseTest::testCallGet
    Test code or tested code did not (only) close its own output buffers

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugVerified issues on the current code behavior or pull requests that will fix themtestingPull requests that changes tests only

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions