Skip to content

insert() doesn't return boolean but CodeIgniter\Database\MySQLi\Result #1365

Description

@bvrignaud

The insert function (in BaseBuilder.php) doesn't return boolean value as documention and php code doc said, but :

  • on success : return CodeIgniter\Database\MySQLi\Result
  • on error : exception

I think, it's more a documention error ?

What do you think ?
I can send you a PR if you want.

CodeIgniter 4 version
develop branch up to date

Affected module(s)
BaseBuilder.php / documention

Context

  • Web server : Apache/2.4.10 (Debian), php 7.1 on docker
  • mariadb on lmde 3

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions