Router issue - overwriting.

[nowackipawel]

I've got two subdomains:
doc and dev.
And my Routes.php is as bellow:

$routes->setDefaultNamespace('App\Controllers');
$routes->setDefaultController('Home');
$routes->setDefaultMethod('index');
...
$routes->get('/', 	'App\Controllers\Site\CDoc::index', ['subdomain' => 'doc', 'as' => 'doc_index']);
$routes->add('/', 'Home::index');

but after request to https://doc.domain I get Home::index instead of App\Controllers\Site\CDoc::index
I thought the first which is matched is used.... but nope.
I did a test and I changed it to:

$routes->add('/', 'Home::index');  // get is working in the same way
$routes->get('/', 	'App\Controllers\Site\CDoc::index', ['subdomain' => 'doc', 'as' => 'doc_index']);

effect still the same - doc.domain is opening Home::index .

OFC everything is working as excepted if dev.domain route to Home::index is defined like that : $routes->add('/', 'Home::index', ['subdomain' => 'dev']);

[lonnieezell]

Well, I think you have the distinction of being the first person to use this in the wild, so will likely need your help debugging this. This can vary wildly, also, based on how the server is setup, etc.

Can you dig in and see what the URL is they system is finding in RouteCollection::determineCurrentSubdomain()?

[nowackipawel]

I've add d($host) at the end of RouteCollection's method.

First config is:

$routes->get('/', 			'App\Controllers\Site\CDoc::index', 	['subdomain' => 'doc', 'as' => 'doc_index']);
$routes->add('/', 'Home::index');

second config is:

$routes->add('/', 'Home::index');
$routes->get('/', 			'App\Controllers\Site\CDoc::index', 	['subdomain' => 'doc', 'as' => 'doc_index']);

and working the same way... in this case (for 2nd config) everything is working ok as for me.

If I use $routes->groups('/', ['subdomain=>'dev/doc']) I could achive what I need as well as with this configs:

$routes->get('/', 			'App\Controllers\Site\CDoc::index', 	['subdomain' => 'doc', 'as' => 'doc_index']);
$routes->add('/', 'Home::index', ['subdomain' => 'dev']);

or

$routes->add('/', 'Home::index', ['subdomain' => 'dev']);
$routes->get('/', 			'App\Controllers\Site\CDoc::index', 	['subdomain' => 'doc', 'as' => 'doc_index']);

I think the same is when I am using hostname instead of sudomain.

Server:

• one ot the newest nginx
• php7.2.x (xubuntu) and php7.3.x (raspbian)

[lonnieezell]

Just pushed up a possible fix for this. Can you pull the latest code and give it a try?

[nowackipawel]

Will update my code in next few days and I'll let you know. I have to compare my base code with my unmerged/rejected PRs.

[nowackipawel]

Ok, I've updated RouteCollection.php only to make quick check.
Unfortunately does not work as expected.

In this case:

$routes->get('/', 			'App\Controllers\Site\CDoc::index', 	['subdomain' => 'doc', 'as' => 'doc_index']);
$routes->add('/', 'Home::index', 	['subdomain' => 'dev']);

everything is working.

$routes->get('/', 			'App\Controllers\Site\CDoc::index', 	['subdomain' => 'doc', 'as' => 'doc_index']);
$routes->add('/', 'Home::index');
or:
$routes->add('/', 'Home::index', 	[ 'as' => 'ddd']);
$routes->get('/', 			'App\Controllers\Site\CDoc::index', 	['subdomain' => 'doc', 'as' => 'doc_index']);
or:

$routes->add('/', 'Home::index', 	[ 'as' => 'ddd']);
$routes->get('/', 			'App\Controllers\Site\CDoc::index', 	['hostname' => 'doc.domain.com', 'as' => 'doc_index']);

still opens Home:index (which is default for main "dev" subdomain) for https://doc.domain.com.

Update: there is no change if I use get() for every route instead of add() for Home::index.