Hi all,
These comments appear throughout the codebase, and to me it is unclear why it is necessary.
//--------------------------------------------------------------------
Some classes with only one method will use it:
|
//-------------------------------------------------------------------- |
Others won't:
|
public function shouldDiscover(string $alias) |
The styleguide does not directly mention where or why such comment would be needed, but it does include one such "separator" on the docblock section.
I feel like it only adds visual bloat and the line breaks between function declarations should already be good enough visual cues, therefore such comments shouldn't be necessary.
I'm happy to create a PR for this if it's agreed upon.
Hi all,
These comments appear throughout the codebase, and to me it is unclear why it is necessary.
Some classes with only one method will use it:
CodeIgniter4/app/Config/Database.php
Line 112 in e609147
Others won't:
CodeIgniter4/app/Config/Modules.php
Line 56 in 22c93a5
The styleguide does not directly mention where or why such comment would be needed, but it does include one such "separator" on the docblock section.
I feel like it only adds visual bloat and the line breaks between function declarations should already be good enough visual cues, therefore such comments shouldn't be necessary.
I'm happy to create a PR for this if it's agreed upon.